Switch to using invoke_result_t

[aprokop]

We have few places that use a combination of decltype and declval that could be simplified by using invoke_result_t (available starting c++17).

[dalg24]

What about

ArborX/test/tstCompileOnlyAccessTraits.cpp

Lines 85 to 88 in 5c55361

	template <class V>
	using deduce_point_t =
	decltype(ArborX::AccessTraits<V, ArborX::PrimitivesTag>::get(
	std::declval<V>(), 0));

ArborX/test/tstNeighborList.cpp

Line 68 in 5c55361

using size_type = decltype(Access::size(std::declval<Points const &>()));

ArborX/benchmarks/dbscan/ArborX_DBSCANVerification.hpp

Lines 175 to 176 in 5c55361

	decltype(Kokkos::create_mirror_view(Kokkos::HostSpace{},
	std::declval<LabelsView>()))

ArborX/src/details/ArborX_DetailsBatchedQueries.hpp

Lines 96 to 97 in 5c55361

	using T = std::decay_t<decltype(Access::get(
	std::declval<Predicates const &>(), std::declval<int>()))>;

ArborX/src/details/ArborX_DetailsDistributedTreeImpl.hpp

Lines 66 to 67 in 5c55361

	using Geometry =
	std::decay_t<decltype(getGeometry(std::declval<Predicate const &>()))>;

ArborX/src/details/ArborX_DetailsDistributedTreeImpl.hpp

Line 71 in 5c55361

using size_type = decltype(Access::size(std::declval<Predicates const &>()));

ArborX/src/details/ArborX_DetailsDistributor.hpp

Lines 276 to 279 in 5c55361

	using DestBufferMirrorViewType =
	decltype(ArborX::Details::create_layout_right_mirror_view_and_copy(
	space, std::declval<typename ImportView::memory_space>(),
	std::declval<ExportViewWithoutMemoryTraits>()));

[aprokop]

What about

I tried those (other than mirror views, those are different as they don't invoke anything), and they seem brittle and depend on compiler. Things like

 using size_type = decltype(Access::size(std::declval<Predicates const &>()));

sometimes worked as

using size_type = std::invoke_result_of<Access::size, Predicates>;

sometimes as

using size_type = std::invoke_result_of<decltype(Access::size), Predicates>;

and sometimes didn't. Access::get was the worst. See these build failures.

So I limited this PR only to the absolutely straightforward cases.

[aprokop]

Rebased on master to take use #937.

[aprokop]

Couple builds failed due to disk space (SYCL and one of the CUDA). Otherwise, good. @dalg24 Do you have any reservations about merging this one?

[dalg24]

Unfortunate that we mix style going forward but sure fine

[aprokop]

Rebased on master.

[aprokop]

HIP did not run, all others passed. Merging.