Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring code to be more modular #6

Closed
wants to merge 62 commits into from
Closed
Show file tree
Hide file tree
Changes from 48 commits
Commits
Show all changes
62 commits
Select commit Hold shift + click to select a range
adfb0b1
refactored code into modules
jeremysee2 Apr 18, 2023
76f4899
refactored image service
jeremysee2 Apr 18, 2023
f026a3e
cleanup imports
jeremysee2 Apr 18, 2023
88ae203
add unit tests for some graph_nav_util functions
jeremysee2 Apr 18, 2023
be35078
pip install requirements
jeremysee2 Apr 18, 2023
86a604f
typing changes
jeremysee2 Apr 18, 2023
f4e9e43
absolute paths
jeremysee2 Apr 18, 2023
03c5997
clone to specific directory
jeremysee2 Apr 18, 2023
89213d8
check file structure for CI
jeremysee2 Apr 18, 2023
1ffab67
check files
jeremysee2 Apr 18, 2023
860c796
check files
jeremysee2 Apr 18, 2023
0097875
add test script
jeremysee2 Apr 18, 2023
5f04353
install spot wrapper
jeremysee2 Apr 18, 2023
7a9811b
install script
jeremysee2 Apr 18, 2023
15addcd
remove asyncimageservice
jeremysee2 Apr 18, 2023
3fa6430
use robot_params to share state variables
jeremysee2 Apr 19, 2023
55c68a1
Pytest replacement (#1)
jeremysee2 Apr 19, 2023
cf262e4
replace print() with self._logger.error()
jeremysee2 Apr 20, 2023
4928997
image publishing works well
jeremysee2 Apr 21, 2023
0c2bb45
moved SPOT_CLIENT_NAME
jeremysee2 Apr 21, 2023
6779aa5
static typing for claim()
jeremysee2 Apr 21, 2023
53fd6bf
Merge branch 'main' of https://github.com/jeremysee2/spot_wrapper int…
jeremysee2 Apr 21, 2023
4881d38
black formatting
jeremysee2 Apr 21, 2023
392da89
comments and passing error feedback
jeremysee2 Apr 22, 2023
22d1084
remove spot_config
jeremysee2 Apr 22, 2023
73d88be
use fstring for short code, move wrench from msg function to class body
heuristicus May 30, 2023
c473eef
Add changes from [SW-62] Elements for publishing the hand camera in s…
heuristicus May 30, 2023
8963fb7
Wrapper for spot cam interaction (#4)
heuristicus Apr 28, 2023
9b20fe1
fix bad indent after cherry-pick
heuristicus Jun 3, 2023
2ea754a
fix formatting
heuristicus Jun 3, 2023
e913cba
fix short code conversion
heuristicus Jun 3, 2023
b5aa382
Always include exception message in response strings (#8)
heuristicus Apr 28, 2023
1da2f3a
fix trajectory status unknown not being reset in trajectory command a…
heuristicus May 5, 2023
f481dfe
Add changes from [SW-127] Add function to get images by cameras (#11)
heuristicus Jun 3, 2023
5d46cda
fix dataclass typing issue for older python versions (20.04), check l…
heuristicus May 19, 2023
b401006
remove old camera task mapping introduced in merge
heuristicus Jun 3, 2023
c9eb351
formatting
heuristicus Jun 3, 2023
056fc25
Add changes from [WUD-126] Add manipulation client (#13)
heuristicus Jun 3, 2023
65347c4
Add changes for added support for the rgb_cameras parameter in spot_r…
heuristicus Jun 3, 2023
3e855a4
Add changes from [SW-141] Checking edge cases in upload_graph (#12)
heuristicus Jun 3, 2023
03c9875
Updated bosdyn to 3.2.3 (#16)
davidwatkins-bdai Jun 1, 2023
3ed105d
[OC-4] Build a Spot Dance Interface (#17)
vgupta-bdai Jun 2, 2023
15ec99a
Merge branch 'main' into jeremysee-main
heuristicus Jun 3, 2023
439965a
formatting
heuristicus Jun 3, 2023
90d60ac
fix startup issues when choreography or arm is not present
heuristicus Jun 3, 2023
7201b3a
small changes to choreo check and output when services are not available
heuristicus Jun 3, 2023
9b7ecf5
better choreo ordering
heuristicus Jun 3, 2023
0a67be9
message when choreo module is missing
heuristicus Jun 3, 2023
5d53c58
cleanup unused spot_image and renamed graphnav private methods
jeremysee2 Jun 9, 2023
17dd90c
update graph_nav private methods
jeremysee2 Jun 9, 2023
bb7c5c1
merge upstream changes
jeremysee2 Jun 9, 2023
0ec8556
custom arm not found Exception
jeremysee2 Jun 9, 2023
651fed6
_get_lease private method in graphNav
jeremysee2 Jun 9, 2023
d64f65f
fix black
heuristicus Jun 10, 2023
7843a48
import ordering and removal of unused imports
heuristicus Jun 10, 2023
e6df481
wait for arm commands to complete rather than sleeping, using block_u…
heuristicus Jun 10, 2023
ea44635
no longer use convenience dict to access robot params in wrapper class
heuristicus Jun 18, 2023
7e9515c
missed some robot params usages in wrapper
heuristicus Jun 18, 2023
8a9d27d
Merge branch 'main' into jeremysee-main
heuristicus Jun 18, 2023
776e840
add block_until_manipulation_completes method
heuristicus Jun 18, 2023
ef2174d
improve arm module comments, manipulation request actually makes use …
heuristicus Jun 18, 2023
94dcde5
Merge branch 'main' into jeremysee-main
heuristicus Jun 26, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 53 additions & 0 deletions .github/workflows/graph_nav_util_test.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,53 @@
name: graph_nav_util unit tests

# Run on every push
on: push

jobs:
test:
runs-on: ubuntu-latest
defaults:
run:
shell: bash

steps:
- name: Make directory
run: mkdir -p ~/spot_wrapper

- name: Checkout repository
uses: actions/checkout@v3
with:
path: spot_wrapper

- name: Check files
run: ls spot_wrapper

- name: Set up Python
uses: actions/setup-python@v2
with:
python-version: "3.8"

- name: Install dependencies
run: |
pip install -r spot_wrapper/requirements.txt
pip install -e spot_wrapper

- name: Run tests
run: pytest --junit-xml=test-results.xml

- name: Surface failing tests
if: always()
uses: pmeier/pytest-summary-gha@main
with:
# A list of JUnit XML files, directories containing the former, and wildcard patterns to process.
path: test-results.xml

# Add a summary of the results at the top of the report
summary: true

# Select which results should be included in the report.
# Follows the same syntax as `pytest -r`
display-options: fEX

# Fail the workflow if no JUnit XML was found.
fail-on-empty: true
1 change: 1 addition & 0 deletions requirements.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
bosdyn_core==3.2.3
protobuf==4.22.1
setuptools==45.2.0
pytest==7.3.1
130 changes: 0 additions & 130 deletions spot_wrapper/graph_nav_util.py

This file was deleted.

Loading