Unrevert unified adblock catalog w/ perf fixes #33621
Labels
feature/shields/adblock
Blocking ads & trackers with Shields
OS/Android
Fixes related to Android browser functionality
OS/Desktop
perf
QA/No
release-notes/exclude
Milestone
brave/brave-core#19946 was reverted by brave/brave-core#20442 due to a performance regression.
The root cause of the regression was that adblock components would generally update in succession, each one triggering a new callback to re-parse the adblock lists and load them into the engine. There is a lot of wasted work, exacerbated in the change to parse lists up-front rather than collecting them all first and parsing at the end.
The regression could be fixed by tracking pending component updates and waiting for all to be completed before reloading the engine. However, it is important to balance this with load at initial app startup, when initial versions of the catalog and lists are not necessarily ready yet.
The text was updated successfully, but these errors were encountered: