no error message in Brave News when wifi is off

[LaurenWags]

Description

When there isn't any wifi, there's no error state/message for Brave News. This occurs on both v1 and v2.

Steps to Reproduce

1. Have a profile with news enabled (but not launched)
2. Turn off wifi for your device
3. Launch the profile
4. Open a new tab and try to access news

Actual result:

1.61.x (v1)	1.62.x (v2)

Expected result:

some kind of message indicating the problem

Reproduces how often:

easily

Brave version (brave://version info)

1.61.x, 1.62.x

Version/Channel Information:

• Can you reproduce this issue with the current release? yes
• Can you reproduce this issue with the beta channel? yes
• Can you reproduce this issue with the nightly channel?

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @brave/qa-team @fallaciousreasoning

[AyushNigam11]

Check the Brave browser settings for any options related to offline behavior.
Ensure that your Brave browser is updated to the latest version.
Experiment with turning off the WiFi and monitoring the behavior across different scenarios to identify patterns.

[fallaciousreasoning]

Yeah, at the moment, we don't handle errors that well at all :/ I might have a quick look and see if we can access/subscribe to the network detection service.

[LaurenWags]

thanks @fallaciousreasoning! since this happens on v1 it would be good to improve with v2 when we can.

[MadhaviSeelam]

Verification PASSED using

Brave | 1.63.110 Chromium: 120.0.6099.217 (Official Build) nightly (64-bit)
-- | --
Revision | f7a7c2ee42626f5a1310c9bd6789d0438e78ca6e
OS | Windows 11 Version 22H2 (Build 22621.3007)

1. Installed 1.63.110
2. launched Brave
3. enabled News via Customize button
4. Followed few sources via Brave news dialog (eg. FirstPost, The Telegraph)
5. close the Brave
6. disconnect WiFi/Network
7. relaunch Brave
8. scroll down to view the feed

Confirmed You appear to be offline message shown

step 4	step 6	step 8

[kjozwiak]

Removing the QA Pass label as the above was uplifted into 1.62.x via brave/brave-core#21545 (review) and will need to be rechecked using 1.62.x using 1.62.138 or higher.

[btlechowski]

Verified with

Brave	1.62.144 Chromium: 120.0.6099.217 (Official Build) beta (64-bit)
Revision	75de8d953f6a5686e425d46d7f0dc9284dc1c064
OS	Linux

Verified test plan from the description

Verified error message is shown

Logged #35361

[MadhaviSeelam]

Verification PASSED using

Brave | 1.62.147 Chromium: 120.0.6099.234 (Official Build) (64-bit)
-- | --
Revision | 3b25c3743150a54485dea24f0ceb1e69d6db51bc
OS | Windows 11 Version 22H2 (Build 22621.3007)

1. Installed 1.62.147
2. launched Brave
3. enabled #brave-news-feed-update via brave://flags
4. enabled Brave news via Customize button
5. closed Brave
6. disconnected WiFi/Network
7. relaunched Brave
8. opened new tab
9. enabled WiFi and clicked Refresh button

• Confirmed You appear to be offline message shown
• Confirmed Brave news feed loaded when clicked Refresh

step 3	step 4	step 6	step 8	step 9

[LaurenWags]

Verified with

Brave | 1.62.147 Chromium: 120.0.6099.234 (Official Build) (x86_64)
-- | --
Revision | 3b25c3743150a54485dea24f0ceb1e69d6db51bc
OS | macOS Version 13.6.3 (Build 22G436)

Scenario 1: Test plan from brave/brave-core#21507 (comment)

1. Start Brave with no internet
2. An error message for "You appear to be offline" should show up
3. Connect
4. Refresh
5. Feed should load
6. Go offline
7. Change feed (should work fine)
8. Refresh
9. Offline message should show

Step 2	Step 4	Step 5	Step 6	Step 7	Step 9

Scenario 2:

1. Installed 1.62.147
2. launched Brave
3. enabled #brave-news-feed-update via brave://flags and relaunched
4. enabled Brave news via Customize button
5. closed Brave
6. disconnected WiFi/Network
7. relaunched Brave
8. opened new tab
9. Clicked on the "News" button at the bottom of the NTP
   ---> Confirmed messaging indicated no internet connection with a Refresh button
10. enabled WiFi
    ---> saw New Content available. Reload? button
11. Clicked Refresh button

• Confirmed You appear to be offline message shown
• Confirmed New content available. Reload? message shown
• Confirmed Brave news feed loaded when clicked Refresh

step 3	step 4	step 6	step 8	step 9	step 10	step 11