-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
no error message in Brave News when wifi is off #35153
Comments
Check the Brave browser settings for any options related to offline behavior. |
Yeah, at the moment, we don't handle errors that well at all :/ I might have a quick look and see if we can access/subscribe to the network detection service. |
thanks @fallaciousreasoning! since this happens on v1 it would be good to improve with v2 when we can. |
Removing the |
Verified with
Verified test plan from the description Verified error message is shown Logged #35361 |
Verification
|
Verified with
Scenario 1: Test plan from brave/brave-core#21507 (comment)
Scenario 2:
|
Description
When there isn't any wifi, there's no error state/message for Brave News. This occurs on both v1 and v2.
Steps to Reproduce
Actual result:
Expected result:
some kind of message indicating the problem
Reproduces how often:
easily
Brave version (brave://version info)
1.61.x, 1.62.x
Version/Channel Information:
Other Additional Information:
Miscellaneous Information:
cc @brave/qa-team @fallaciousreasoning
The text was updated successfully, but these errors were encountered: