Disable MakeCohortVcfMetrics by default to avoid pesky resource errors #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwalker174
approved these changes
Apr 29, 2024
There was a problem hiding this comment.
Looks good. We should do this in other modules as well, as we're discussing in #633.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Multiple users have encountered out-of-memory errors in MakeCohortVcfMetrics with larger cohorts. It can be costly to rerun CleanVcf with updated resources for very large cohorts. This metrics collection is meant for development and is not necessary for users to run every time, so it can be safely disabled. An alternative would be to increase the default memory, but it is enough memory for the test set and unnecessary to run for large cohorts so this seems more efficient.