Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace sv_pipeline_base_docker with sv_pipeline_docker #634

Merged

Conversation

VJalili
Copy link
Member

@VJalili VJalili commented Jan 31, 2024

A follow-up from #633

Since both sv_pipeline_base_docker and sv_pipeline_docker are references to the same docker image, this PR implements the following changes to consolidate them:

  • If a workflow has both sv_pipeline_docker and sv_pipeline_base_docker, remove sv_pipeline_base_docker and replaces all runtime references with sv_pipeline_docker.
  • If a workflow does not have sv_pipeline_docker, then rename sv_pipeline_base_docker to sv_pipeline_docker.
  • Update all the templates according to the above changes.

A few other docker image variables also use the same image as sv_pipeline_docker. I will update these variables similarly in follow-up PRs.

@VJalili VJalili marked this pull request as ready for review January 31, 2024 17:43
Copy link
Collaborator

@mwalker174 mwalker174 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This has been a long time coming. I hope you didn't have to do it all by hand :)

@VJalili
Copy link
Member Author

VJalili commented Feb 2, 2024

Thank you, @mwalker174!

I hope you didn't have to do it all by hand :)

I did! :) I think that was the only option to make sure the changes were correctly applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants