Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipe for urdfdom-py python package #21870

Merged
merged 26 commits into from
May 3, 2023

Conversation

traversaro
Copy link
Contributor

@traversaro traversaro commented Jan 26, 2023

The recipe is a bit strange, as it is a Python library, but with the following constraints:

  • It installs metadata for the ament's resource_index, that is installed according in the canonical install_prefix , so it is different between Windows (${CONDA_PREFIX}/Library) and other operating systems (${CONDA_PREFIX}). So even if it is technically noarch as the python library installed is pure python, the package cannot be noarch: python.
  • The python package install a command/entry_point display_urdf, that however is not meant to be used directly, but called via ros2 run helper (see Fix the binary install location. ros/urdf_parser_py#74), so it should not be installed in <install_prefix>/bin, but rather in <install_prefix>/lib/urdfdom_py. To do so, it is necessary to install the library not via python -m pip install ., but with the deprecatated use of python setup.py . Anyhow, this is going to be fixed upstream (see setup.py deprecation warning colcon/colcon-core#454), so the use of python setup.py is just a temporary workaround.

See RoboStack/ros-humble#40 for more context.

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/urdfdom-py) and found some lint.

Here's what I've got...

For recipes/urdfdom-py:

  • If python is a host requirement, it should be a run requirement.
  • Non noarch packages should have python requirement without any version constraints.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/urdfdom-py) and found it was in an excellent condition.

@traversaro
Copy link
Contributor Author

@conda-forge/help-python The PR is ready for review.

fyi @Tobias-Fischer @wolfv

Copy link
Contributor

@Tobias-Fischer Tobias-Fischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm thanks!

@Tobias-Fischer
Copy link
Contributor

@conda-forge/help-python @wolfv could you please take a look?

@traversaro
Copy link
Contributor Author

@conda-forge/help-python The PR is ready for review.

fyi @Tobias-Fischer @wolfv

Not sure if perhaps it is helpful to also tag @conda-forge/staged-recipes, thanks!

@wolfv wolfv merged commit 183ccb4 into conda-forge:main May 3, 2023
@traversaro
Copy link
Contributor Author

Thanks @wolfv !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants