-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add recipe for urdfdom-py python package #21870
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/urdfdom-py:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@conda-forge/help-python The PR is ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm thanks!
@conda-forge/help-python @wolfv could you please take a look? |
Not sure if perhaps it is helpful to also tag @conda-forge/staged-recipes, thanks! |
Thanks @wolfv ! |
The recipe is a bit strange, as it is a Python library, but with the following constraints:
resource_index
, that is installed according in the canonicalinstall_prefix
, so it is different between Windows (${CONDA_PREFIX}/Library
) and other operating systems (${CONDA_PREFIX}
). So even if it is technicallynoarch
as the python library installed is pure python, the package cannot benoarch: python
.display_urdf
, that however is not meant to be used directly, but called viaros2 run
helper (see Fix the binary install location. ros/urdf_parser_py#74), so it should not be installed in<install_prefix>/bin
, but rather in<install_prefix>/lib/urdfdom_py
. To do so, it is necessary to install the library not viapython -m pip install .
, but with the deprecatated use ofpython setup.py
. Anyhow, this is going to be fixed upstream (see setup.py deprecation warning colcon/colcon-core#454), so the use ofpython setup.py
is just a temporary workaround.See RoboStack/ros-humble#40 for more context.
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).