Added support for LZ4_RAW compression codec for Parquet #4446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malhotrashivam
added
feature request
niloc132
reviewed
Sep 6, 2023
...et/table/src/brotliTest/java/io/deephaven/parquet/table/BrotliParquetTableReadWriteTest.java
Show resolved
Hide resolved
extensions/parquet/table/src/main/java/io/deephaven/parquet/table/ParquetTools.java
Show resolved
Hide resolved
...nsions/parquet/table/src/test/java/io/deephaven/parquet/table/ParquetTableReadWriteTest.java
Show resolved
Hide resolved
malhotrashivam
requested review from
chipkent and
jmao-denver
as code owners
chipkent
previously approved these changes
Sep 6, 2023
niloc132
previously approved these changes
Sep 6, 2023
rcaudy
reviewed
Sep 13, 2023
...ession/src/main/java/io/deephaven/parquet/compress/LZ4WithLZ4RawBackupCompressorAdapter.java
Show resolved
Hide resolved
malhotrashivam
commented
Sep 14, 2023
...ession/src/main/java/io/deephaven/parquet/compress/LZ4WithLZ4RawBackupCompressorAdapter.java
Outdated
Show resolved
Hide resolved
rcaudy
previously approved these changes
Sep 15, 2023
...ession/src/main/java/io/deephaven/parquet/compress/LZ4WithLZ4RawBackupCompressorAdapter.java
Show resolved
Hide resolved
malhotrashivam
force-pushed
the
sm-pq-lz4-raw
branch
from
35dffb7
to
a4fb2f6
Compare
niloc132
reviewed
Sep 18, 2023
extensions/parquet/table/src/main/java/io/deephaven/parquet/table/ParquetTools.java
Show resolved
Hide resolved
malhotrashivam
force-pushed
the
sm-pq-lz4-raw
branch
from
43034fb
to
7107d85
Compare
niloc132
approved these changes
Sep 18, 2023
rcaudy
approved these changes
Sep 18, 2023
|
Labels indicate documentation is required. Issues for documentation have been opened: How-to: https://github.com/deephaven/deephaven.io/issues/3199 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3148
Also, added a new adapter for LZ4 which tries to decompress a file with LZ4_RAW decompressors in case it fails with LZ4 decompressors. The retry mechanism is particularly useful for decompressing parquet files that are compressed with LZ4_RAW but tagged as LZ4 in the metadata.
These are some interesting links to read about the LZ4 format and LZ4_RAW or LZ4 Block format
Documentation Update:
ParquetInstructionsargument:ParquetTools.UNCOMPRESSED- The output will not be compressed.ParquetTools.SNAPPY- Aims for high speed, and a reasonable amount of compression, based on Snappy compression format by Google.ParquetTools.LZ4_RAW- A codec based on the LZ4 block format , recommended to use instead ofParquetTools.LZ4.ParquetTools.LZ4, mention that this is deprecated and users should useParquetTools.LZ4_RAW.ParquetInstructionsnot specified will default toParquetTools.SNAPPYcompression format.Similar changes to be done for the python page.
Overall, there should be 7 compression formats now
UNCOMPRESSED,LZ4,LZ4_RAW,LZO,GZIP,ZSTD,SNAPPYwith default beingSNAPPYand we need to update the documentation everywhere to reflect this. For Java pages, they are referred asParquetTools.<format>(exampleParquetTools.LZ4) and for python, we refer them as"<format>"(example"LZ4").