Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20055] Fix colcon on github CI #4075

Merged
merged 3 commits into from
Nov 30, 2023
Merged

[20055] Fix colcon on github CI #4075

merged 3 commits into from
Nov 30, 2023

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Nov 30, 2023 •
edited by MiguelCompany
Loading

Description

This PR fixes Github CIs. The failure is caused by a regression in colcon-core and has been mitigated on eProsima-CI v0.6.0:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A: The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Changes are ABI compatible.
  • N/A: Changes are API compatible.
  • N/A: New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@EduPonz
Refs #20055: Fix colcon on github CI
2947f80 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
@EduPonz EduPonz added this to the v2.13.0 milestone Nov 30, 2023
@EduPonz EduPonz mentioned this pull request Nov 30, 2023
Merged
@EduPonz
Refs #20055: Install colcon and python deps for documentation using e…
ad9ead2 
…Prosima-CI

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
MiguelCompany
MiguelCompany previously approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green github CI

@MiguelCompany MiguelCompany added the ci-pending PR which CI is running label Nov 30, 2023
JesusPoderoso
JesusPoderoso previously approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EduPonz
Copy link
Author

EduPonz commented Nov 30, 2023

@Mergifyio backport 2.12.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 30, 2023 •
edited
Loading

backport 2.12.x

✅ Backports have been created

@EduPonz
Refs #20055: Windows CI: Fail on build failure
d7d715c 
Signed-off-by: EduPonz <eduardoponz@eprosima.com>
This was referenced Nov 30, 2023
Merged
Merged
Merged
@MiguelCompany MiguelCompany added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Nov 30, 2023
@EduPonz EduPonz merged commit 2359f49 into master Nov 30, 2023
9 checks passed
@EduPonz EduPonz deleted the hotfix/github_ci branch November 30, 2023 14:41
mergify bot pushed a commit that referenced this pull request Nov 30, 2023
@EduPonz @mergify
Fix colcon on github CI (#4075)
2bf5054 
* Refs #20055: Fix colcon on github CI

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20055: Install colcon and python deps for documentation using eProsima-CI

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20055: Windows CI: Fail on build failure

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
(cherry picked from commit 2359f49)
@mergify mergify bot mentioned this pull request Nov 30, 2023
Merged
EduPonz added a commit that referenced this pull request Dec 4, 2023
@mergify @EduPonz
Fix colcon on github CI (#4075) (#4077)
89a5117 
* Refs #20055: Fix colcon on github CI

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20055: Install colcon and python deps for documentation using eProsima-CI

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

* Refs #20055: Windows CI: Fail on build failure

Signed-off-by: EduPonz <eduardoponz@eprosima.com>

---------

Signed-off-by: EduPonz <eduardoponz@eprosima.com>
(cherry picked from commit 2359f49)

Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiguelCompany MiguelCompany MiguelCompany approved these changes

@JesusPoderoso JesusPoderoso JesusPoderoso left review comments

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v2.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@EduPonz @MiguelCompany @JesusPoderoso