New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent nil pointer panic because of nonexist attribute of Access Log #1838

Merged

zirain merged 4 commits into envoyproxy:main from ardikabs:fix/1830

Sep 4, 2023

Merged

fix: prevent nil pointer panic because of nonexist attribute of Access Log #1838

Merge branch 'main' into fix/1830

This check has been archived and is scheduled for deletion. Learn more about checks retention

Codecov / codecov/patch succeeded Sep 4, 2023 in 1s

71.73% of diff hit (target 60.00%)

View this Pull Request on Codecov

71.73% of diff hit (target 60.00%)

Annotations

Check warning on line 182 in api/config/v1alpha1/validation/validate.go

codecov / codecov/patch

api/config/v1alpha1/validation/validate.go#L181-L182

Added lines #L181 - L182 were not covered by tests

Check warning on line 197 in api/config/v1alpha1/validation/validate.go

codecov / codecov/patch

api/config/v1alpha1/validation/validate.go#L193-L197

Added lines #L193 - L197 were not covered by tests

Check warning on line 211 in api/config/v1alpha1/validation/validate.go

codecov / codecov/patch

api/config/v1alpha1/validation/validate.go#L207-L211

Added lines #L207 - L211 were not covered by tests

View more details on Codecov