Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent nil pointer panic because of nonexist attribute of Access Log #1838

Merged
merged 4 commits into from
Sep 4, 2023

Merge branch 'main' into fix/1830

9f74d04
Select commit
Loading
Failed to load commit list.
Merged

fix: prevent nil pointer panic because of nonexist attribute of Access Log #1838

Merge branch 'main' into fix/1830
9f74d04
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Codecov / codecov/project succeeded Sep 4, 2023 in 0s

65.36% (target 60.00%)

View this Pull Request on Codecov

65.36% (target 60.00%)

Details

Codecov Report

Merging #1838 (9f74d04) into main (f31fbaa) will increase coverage by 0.30%.
The diff coverage is 71.73%.

@@            Coverage Diff             @@
##             main    #1838      +/-   ##
==========================================
+ Coverage   65.06%   65.36%   +0.30%     
==========================================
  Files          86       86              
  Lines       12480    12526      +46     
==========================================
+ Hits         8120     8188      +68     
+ Misses       3838     3821      -17     
+ Partials      522      517       -5     
Files Changed Coverage Δ
api/config/v1alpha1/validation/validate.go 73.38% <70.45%> (-1.36%) ⬇️
internal/gatewayapi/listener.go 97.68% <100.00%> (+6.45%) ⬆️

... and 2 files with indirect coverage changes