Fix make verify
#11
Merged
Fix make verify
#11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After Use central and new manifest format gardener/documentation#431, the repos do no longer needs to define a .docforge dir and the manifests are maintained centrally.
gardener-robot
added
area/auto-scaling
gardener-robot-ci-3
added
reviewed/ok-to-test
Such action exists in provider extensions repos and is mainly used to prevent Gardener maintainers to merge PRs when the extension is in release validation. I doubt that for this repo we will have such cases as Gardener maintainers currently don't have merge rights and I don't expect them to actively create PRs against this repo.
gardener-robot-ci-3
added
reviewed/ok-to-test
29 tasks
gardener-robot-ci-3
added
reviewed/ok-to-test
It should not be required in any of the local setups
gardener-robot-ci-3
added
reviewed/ok-to-test
gardener-robot-ci-2
added
reviewed/ok-to-test
This was referenced Mar 25, 2024
Merged
gardener-robot
added
the
status/closed
andrerun
pushed a commit
that referenced
this pull request
Mar 26, 2024
* Fix `make check` * Drop `make check-docforge` * Fix `make format` * `make format` * Fix `make test` * `make verify-extended`: Do not run tests 2 times * Drop the release milestone GitHub action * Switch the base image to distroless * Add .gitignore entry for file named TODO * Clean up the Makefile * Drop the image pull secret from the example * Clean up go.mod from unnecessary comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to categorize this PR?
/area auto-scaling
/kind bug
What this PR does / why we need it:
This PR fixes the
make verifyandmake verify-extendedtargets.Which issue(s) this PR fixes:
Part of #5
Special notes for your reviewer:
I additionally pushed 3ad6582 to make PR/release jobs to execute
make verify.Release note: