-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ESIMD][NFC] Rework the L1/L2 cache hints passing across internal funcs #12899
[ESIMD][NFC] Rework the L1/L2 cache hints passing across internal funcs #12899
Conversation
034a90c
to
a657f7c
Compare
Cache-hints: * cache_hint and cache_level were also moved to memory_properties.hpp * added check_cache_hints() function accepting PropertyListT instead of L1/L2 template parameters. Restructures in block_Load: * block_load_impl() functions now accept template param PropertyListT instead of L1H, L2H and alignment FlagsT. * only block_load_impl functions call check_cache_hints() now. * Replaced the uses of lsc.load.stateless with lsc.load.merge.stateless It does not change the GPU code-gen, it is identical. Signed-off-by: Klochkov, Vyacheslav N <vyacheslav.n.klochkov@intel.com>
a657f7c
to
35c0956
Compare
…2 and FlagsT Signed-off-by: Klochkov, Vyacheslav N <vyacheslav.n.klochkov@intel.com>
35c0956
to
5fc647c
Compare
The Linux failures seem like they might be related. If not let me know and I will review this now. |
It is interesting that SYCLOS has extra new GPU driver now - 1.3.28454. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, really cool cleanup. just a minor question
This is the 1st patch in the upcoming series of similar patches.
Cache-hints:
L1/L2 template parameters.
Restructures in block_load:
instead of L1H, L2H and alignment FlagsT.
It does not change the GPU code-gen, it is identical.
Restructures in block_store:
instead of L1H, L2H and alignment FlagsT.