[UR] Bump UR version and enable dynamic linking with UMF #13343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@igchor Does this mean that we will be requiring ANYONE who use UR to install libhwloc on Linux and hwloc-win64-build-2.10.0 on windows? Can we somehow detect these, and don't switch to dynamic linking if these libs are not installed? |
Yes, that's correct (although the minimum required version is 2.3.0). The hwloc is required not because we link dynamically with UMF but because I've bumped UMF version we are using. This new UMF version has a dependency on hwloc which cannot be disabled. Will this be a problem for intel/llvm? |
Thanks @igchor for the clarification. Installing hwloc in CI/containers won't be a problem. But that also means sycl compilers and DPC++ will have to add a dependency to hwloc? If so, I think we have to update quite a bunch of documents to reflect that? Is that really what we want? FYI. @stdale-intel . |
|
@jsji you are correct on both ends. @uditagarwal97 updated the Windows CI machines, and Linux containers. Docs and other things are being updated to reflect this as well. |
Yes, and there's already been a discussion about how to handle this for DPC++.
@jsji do you want me to update any docs in intel/llvm in this PR? if yes, could you let me know which ones should I update? |
Thanks @igchor . I think @stdale-intel mentioned that "Docs and other things are being updated to reflect this as well." , not sure who is doing that, but I guess someone is already taking care of that. |
|
@igchor if you can take care of the intel/llvm doc PR that would be awesome! I'd start with editing https://github.com/intel/llvm/blob/sycl/sycl/doc/GetStartedGuide.md. But i'll see if there is other docs as well. |
Done. Please let me know if I should update anything else. |
steffenlarsen
pushed a commit
that referenced
this pull request
Apr 24, 2024
Install hwloc which is required by UMF (a dependency of UR). This is needed by #13343
Explicitly set 'ZES_ENABLE_SYSMAN=0'. HWLOC initializes this environment variable in its constructor, causing this test to fail, as retrieving free memory information is expected not to work in this test.
kswiecicki
force-pushed
the
ur_dynamic_umf
branch
from
1d617bf
to
8a5f65c
Compare
pbalcer
approved these changes
Jul 25, 2024
|
@intel/llvm-gatekeepers this is ready for merge from our side. The HIP failure is unrelated and is affecting all other PRs. |
|
@pbalcer this is waiting on approvals from intel/dpcpp-devops-reviewers, intel/dpcpp-doc-reviewers, and/or intel/llvm-reviewers-runtime |
sarnex
approved these changes
Jul 25, 2024
uditagarwal97
approved these changes
Jul 25, 2024
@martygrant, since @sarnex and @uditagarwal97 have given their approval, I believe this is ready to be merged |
|
Don't we still need |
I'm not sure, @martygrant said |
|
The CI seems to be saying |
steffenlarsen
approved these changes
Jul 25, 2024
Co-authored-by: Steffen Larsen <steffen.larsen@intel.com>
|
@intel/llvm-gatekeepers this is ready for merge, I belive we have all the required approvals now |
|
@igchor, this PR broke our post-commit, could you please take a look? https://github.com/intel/llvm/actions/runs/10106492701 |
|
CI on macOS is also broken: |
|
@pbalcer, would you be able to have a look at the above? |
We are working on a fix. Will create a PR soon. |
|
hdelan
pushed a commit
to hdelan/llvm
that referenced
this pull request
Jul 26, 2024
Testing PR for: oneapi-src/unified-runtime#1430 --------- Co-authored-by: Krzysztof Swiecicki <krzysztof.swiecicki@intel.com> Co-authored-by: Steffen Larsen <steffen.larsen@intel.com>
steffenlarsen
pushed a commit
that referenced
this pull request
Jul 26, 2024
`hwloc` became a dependency after #13343 was merged. CI infrastructure has been updated to have `hwloc` installed, but it's still missing on macOS runner. Additionally, UMF compile options caused errors on SYCL runners that should be resolved after UR version bump included in this patch. Logs: https://github.com/intel/llvm/actions/runs/10106492701/job/27948711331 and https://github.com/intel/llvm/actions/runs/10106492701/job/27948711538.
Note this is NOT true, it turns out that we haven't have hwloc installed in ANY of our internal build system, so I am going to revert this in sycl-web first to unblock pulldown. This means this (and any new UR changes) will NOT be pulldown into downstream until we get the internal build system fixed , I have contacted our infrastructure team, hopefully they can help to install it ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing PR for: oneapi-src/unified-runtime#1430