Refactored create machine tests #345
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukas016
force-pushed
the
osc/enh/tests
branch
from
7cebdb9 to
10f0f7e
Compare
lukas016
force-pushed
the
osc/enh/tests
branch
12 times, most recently
from
22ac246 to
894bf0e
Compare
lukas016
force-pushed
the
osc/enh/tests
branch
from
894bf0e to
a5a876b
Compare
lukas016
reviewed
Sep 24, 2024
| DeferCleanup(libvirtConn.ConnectClose) | ||
| }) | ||
|
|
||
| func isSocketAvailable(socketPath string) error { |
There was a problem hiding this comment.
this function is defined multiple times. Probably whole server_suite_test.go were copied. It has to be refactor.
lukas016
reviewed
Sep 24, 2024
| @@ -107,6 +107,10 @@ test: manifests generate fmt vet envtest ## Run tests. Some test depend on Linux | |||
| integration-tests: ## Run integration tests against code. For dependencies, refer to the integration-test workflow. | |||
| go run github.com/onsi/ginkgo/v2/ginkgo run -r --label-filter="integration" -coverprofile cover.out | |||
|
|
|||
| # .PHONY: integration-tests | |||
There was a problem hiding this comment.
this is duplicity. it can be deleted.
lukas016
reviewed
Sep 24, 2024
| @@ -101,7 +101,7 @@ var _ = Describe("ListEvents", func() { | |||
|
|
|||
| By("listing the machine events with matching label filter and non matching time filter") | |||
| resp, err = machineClient.ListEvents(ctx, &iri.ListEventsRequest{Filter: &iri.EventFilter{ | |||
| LabelSelector: map[string]string{machinepoolletv1alpha1.MachineUIDLabel: "foobar"}, | |||
| LabelSelector: map[string]string{machinepoolletv1alpha1.MachineUIDLabel: "eventlist"}, | |||
lukas016
reviewed
Sep 24, 2024
| pluginOpts := networkinterfaceplugin.NewDefaultOptions() | ||
| pluginOpts.PluginName = "isolated" | ||
|
|
||
| // tempDir = "/home/pcmil/libvirt-provider/temptest" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fixes #