Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes and improvements for point selection in O3DVisualizer (fixes #6725) #6733

Merged
merged 4 commits into from
Apr 17, 2024
Merged

Fixes and improvements for point selection in O3DVisualizer (fixes #6725) #6733

merged 4 commits into from
Apr 17, 2024

Conversation

danrauch
Copy link
Contributor

@danrauch danrauch commented Mar 29, 2024 •
edited
Loading

Fixes and improvements:

  • make points removable by correctly forwarding the key modifier to the already implemented function
  • fix bounding box calculation for picked point size selection (manual bbox extend calculation was wrong)
  • fix crash occurring when trying to make selection and non-pickable geometries where in scene

Type

Motivation and Context

See issue

Checklist:

  • I have run python util/check_style.py --apply to apply Open3D code style
    to my code.
  • This PR changes Open3D behavior or adds new functionality.
    • Both C++ (Doxygen) and Python (Sphinx / Google style) documentation is
      updated accordingly.
    • I have added or updated C++ and / or Python unit tests OR included test
      results       (e.g. screenshots or numbers) here.
  • I will follow up and update the code if CI fails.

Description

See issue

@danrauch
Fix isl-org#6725: O3DVisualizer: make points removable and fix point …
d905a36 
…size calc

Correctly forward keymodifier to enable point removing and fix bounding
box calculation for picked point size selection.
@update-docs Update Docs
Copy link

update-docs bot commented Mar 29, 2024

Thanks for submitting this pull request! The maintainers of this repository would appreciate if you could update the CHANGELOG.md based on your changes.

@danrauch
Apply style
0c9f41d
@danrauch
Fix crash occuring when trying to make selection and non-pickable geo…
3137df6 
…metries where in scene

Error example:
[Open3D Error] (void open3d::visualization::gui::SelectionIndexLookup::Add(const string&, size_t))
start_index 3248 must be larger than all previously added objects 3248.
@danrauch danrauch changed the title Fix #6725: O3DVisualizer: make points removable and fix point size calc Fixes and improvements for point selection in O3DVisualizer (fixes #6725) Mar 29, 2024
errissa
errissa requested changes Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@errissa errissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good other than the MacOS issue. Please resolve the CI failures and feel free to let me know if you need any help with it. Thank you for your contribution!

cpp/open3d/visualization/visualizer/O3DVisualizer.cpp Outdated Show resolved Hide resolved
@danrauch danrauch requested a review from errissa April 17, 2024 11:12
@ssheorey
Copy link
Member

Good to merge once CI passes. Thanks @danrauch for this useful bugfix.

@ssheorey ssheorey merged commit 5c39bc0 into isl-org:main Apr 17, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssheorey ssheorey ssheorey approved these changes

@errissa errissa Awaiting requested review from errissa

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@danrauch @ssheorey @errissa