Fix package install: remove use of deprecated setuptools.command.test #856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connortann
changed the title
|
I've pushed what I think is a more ambitious version, which pins all dependencies; but also uses poetry. Right now all the fixes avoid complexity in specifying dependencies, which pushes that complexity to consumers. This is a good fix |
graingert
reviewed
Jul 29, 2024
A release isn't that urgent as the setuptools removal was reverted |
|
Thanks for the quick fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #855 , fixes #854
At present the package install fails in typical conditions, as it is incompatible with the latest setuptools. The failure can be reproduced with:
pip wheel --no-cache-dir --use-pep517 "vcrpy (==6.0.1)"This PR removes the used of deprecated setuptools modules, which has led to the package build breaking when installed in isolated environments.
Once this issue is fixed it would be useful to make a swift patch release, as it appears this issue is having quite a large affect on the wider python ecosystem:
pypa/setuptools#4519