-
Notifications
You must be signed in to change notification settings - Fork 181
faq 202473477
by Andreas Neumann on 2018-03-05 09:50:43
That pull request from last Friday evening left me somewhat confused. commented with Let me know what you think and requested two reviews. The same evening requested another two reviews including himself. Despite the fact that none had been answered, the next morning, everything got merged.
I am not interested in the content of that particular pull request. My question is more general towards how do we merge and what rules do we follow here. May also be the case that I just fail to see the reason for those review requests.
by Joschka Bischoff on 2018-03-05 10:55:50
From my point of view:
There is no commit policy. I.e., as soon as a pull request has passed all tests, it can be merged.
The change to use PRs was a decision to ensure that the master never fails, not to limit edits per se.
That said, Amit, Michael and I discussed the PR internally and found it useful. Since neither of the requested reviewers was available for immediate review, we changed the reviewer before merging. There was a certain time pressure attached to it, as the PR was meant to be included for the 0.10.-release. The deadline for that was Friday evening.
by Michael Zilske on 2018-03-05 17:34:17
I think there is no policy. I mean, why can't I request comments? Or why does that imply that I have to do that?
You are viewing an archive of the previous MATSim Q&A site. The real site is now at https://matsim.org/faq