Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a welcome window to set username for guests #10467

Merged
merged 4 commits into from
Sep 12, 2023
Merged

Add a welcome window to set username for guests #10467

merged 4 commits into from
Sep 12, 2023

Conversation

DorraJaouad
Copy link
Contributor

@DorraJaouad DorraJaouad commented Sep 5, 2023 •
edited
Loading

☑️ Resolves

  • The window is shown only when there is no username set previously.

🖼️ Screenshots

🏚️ Chat View 🏡 Lobby view
image image

🚧 Tasks

  • visual review
  • code review

🏁 Checklist

@DorraJaouad DorraJaouad self-assigned this Sep 5, 2023
@DorraJaouad DorraJaouad added enhancement feature: frontend 🖌️ "Web UI" client feature: meetings 📅 Covering the webinary usecase incl. Lobby feature: chat 💬 Chat and system messages labels Sep 5, 2023
@DorraJaouad DorraJaouad added this to the 💙 Next Major (28) milestone Sep 5, 2023
szaimen
szaimen reviewed Sep 5, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @DorraJaouad looks pretty good already but I have one small suggestions

src/components/GuestWelcomeWindow.vue Outdated Show resolved Hide resolved
@DorraJaouad DorraJaouad force-pushed the feat/855/set-username-for-guest branch from d901f2f to 3359cd1 Compare September 5, 2023 10:20
szaimen
szaimen approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from design perspective :)

Antreesy
Antreesy reviewed Sep 5, 2023
View reviewed changes
src/components/ChatView.vue Outdated Show resolved Hide resolved
src/components/GuestWelcomeWindow.vue Outdated Show resolved Hide resolved
src/components/GuestWelcomeWindow.vue Show resolved Hide resolved
src/components/GuestWelcomeWindow.vue Outdated Show resolved Hide resolved
src/components/GuestWelcomeWindow.vue Outdated Show resolved Hide resolved
src/components/GuestWelcomeWindow.vue Outdated Show resolved Hide resolved
src/components/GuestWelcomeWindow.vue Outdated Show resolved Hide resolved
src/components/GuestWelcomeWindow.vue Show resolved Hide resolved
src/components/GuestWelcomeWindow.vue Outdated Show resolved Hide resolved
src/components/GuestWelcomeWindow.vue Outdated Show resolved Hide resolved
@DorraJaouad
Add a welcome window to set username for guests
1582e24 
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad
Move the method to the guestNameStore and don't use setGuestUsername …
b355c9d 
…in the welcome window and other refactoring

Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the feat/855/set-username-for-guest branch from ab2a542 to fb8237d Compare September 11, 2023 12:48
@DorraJaouad
Move the submitGuestUsername to the store
7e71728 
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the feat/855/set-username-for-guest branch from fb8237d to 7e71728 Compare September 11, 2023 12:50
@DorraJaouad
Copy link
Contributor Author

Rebased onto master

@szaimen szaimen requested a review from Antreesy September 11, 2023 14:40
Antreesy
Antreesy reviewed Sep 11, 2023
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny things before you'll push again with tests

src/components/ChatView.vue Outdated Show resolved Hide resolved
src/components/GuestWelcomeWindow.vue Outdated Show resolved Hide resolved
src/components/GuestWelcomeWindow.vue Show resolved Hide resolved
src/components/GuestWelcomeWindow.vue Outdated Show resolved Hide resolved
@DorraJaouad DorraJaouad force-pushed the feat/855/set-username-for-guest branch 3 times, most recently from 9d05b81 to 403849f Compare September 12, 2023 10:05
Antreesy
Antreesy approved these changes Sep 12, 2023
View reviewed changes
src/components/SetGuestUsername.vue Outdated Show resolved Hide resolved
@DorraJaouad
Add tests and renaming
168bb5d 
Signed-off-by: DorraJaouad <dorra.jaoued7@gmail.com>
@DorraJaouad DorraJaouad force-pushed the feat/855/set-username-for-guest branch from 403849f to 168bb5d Compare September 12, 2023 12:32
@DorraJaouad DorraJaouad merged commit 7736c08 into master Sep 12, 2023
23 checks passed
@DorraJaouad DorraJaouad deleted the feat/855/set-username-for-guest branch September 12, 2023 12:45
@szaimen
Copy link
Contributor

szaimen commented Sep 12, 2023

🎉🎉🎉

@nickvergessen nickvergessen mentioned this pull request Sep 19, 2023
Open
@nickvergessen nickvergessen mentioned this pull request Oct 10, 2023
Closed
@juliusknorr juliusknorr mentioned this pull request Dec 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

@Antreesy Antreesy Antreesy approved these changes

Assignees

@DorraJaouad DorraJaouad

Labels
enhancement feature: chat 💬 Chat and system messages feature: frontend 🖌️ "Web UI" client feature: meetings 📅 Covering the webinary usecase incl. Lobby
Projects
None yet
Milestone
v18.0.0-beta.1
Development

Successfully merging this pull request may close these issues.

👤 Ask Guest to enter a name when connecting
3 participants
@DorraJaouad @szaimen @Antreesy