Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): Move v4 client instantiation to reconcileDelete #465

Merged
merged 6 commits into from
Jul 31, 2024

fix lint issues

68e55a6
Select commit
Loading
Failed to load commit list.
Merged

fix(controller): Move v4 client instantiation to reconcileDelete #465

fix lint issues
68e55a6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Jul 31, 2024 in 1s

7.81% of diff hit (target 75.00%)

View this Pull Request on Codecov

7.81% of diff hit (target 75.00%)

Annotations

Check warning on line 320 in controllers/nutanixmachine_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

controllers/nutanixmachine_controller.go#L317-L320 

Added lines #L317 - L320 were not covered by tests

Check warning on line 328 in controllers/nutanixmachine_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

controllers/nutanixmachine_controller.go#L323-L328 

Added lines #L323 - L328 were not covered by tests

Check warning on line 335 in controllers/nutanixmachine_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

controllers/nutanixmachine_controller.go#L331-L335 

Added lines #L331 - L335 were not covered by tests

Check warning on line 344 in controllers/nutanixmachine_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

controllers/nutanixmachine_controller.go#L343-L344 

Added lines #L343 - L344 were not covered by tests

Check warning on line 353 in controllers/nutanixmachine_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

controllers/nutanixmachine_controller.go#L347-L353 

Added lines #L347 - L353 were not covered by tests

Check warning on line 358 in controllers/nutanixmachine_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

controllers/nutanixmachine_controller.go#L356-L358 

Added lines #L356 - L358 were not covered by tests

Check warning on line 360 in controllers/nutanixmachine_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

controllers/nutanixmachine_controller.go#L360 

Added line #L360 was not covered by tests

Check warning on line 364 in controllers/nutanixmachine_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

controllers/nutanixmachine_controller.go#L362-L364 

Added lines #L362 - L364 were not covered by tests

Check warning on line 366 in controllers/nutanixmachine_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

controllers/nutanixmachine_controller.go#L366 

Added line #L366 was not covered by tests

Check warning on line 368 in controllers/nutanixmachine_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

controllers/nutanixmachine_controller.go#L368 

Added line #L368 was not covered by tests

Check warning on line 376 in controllers/nutanixmachine_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

controllers/nutanixmachine_controller.go#L371-L376 

Added lines #L371 - L376 were not covered by tests

Check warning on line 385 in controllers/nutanixmachine_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

controllers/nutanixmachine_controller.go#L381-L385 

Added lines #L381 - L385 were not covered by tests

Check warning on line 387 in controllers/nutanixmachine_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

controllers/nutanixmachine_controller.go#L387 

Added line #L387 was not covered by tests

Check warning on line 396 in controllers/nutanixmachine_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

controllers/nutanixmachine_controller.go#L392-L396 

Added lines #L392 - L396 were not covered by tests

Check warning on line 398 in controllers/nutanixmachine_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

controllers/nutanixmachine_controller.go#L398 

Added line #L398 was not covered by tests

Check warning on line 401 in controllers/nutanixmachine_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

controllers/nutanixmachine_controller.go#L400-L401 

Added lines #L400 - L401 were not covered by tests

Check warning on line 416 in controllers/nutanixmachine_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

controllers/nutanixmachine_controller.go#L414-L416 

Added lines #L414 - L416 were not covered by tests

Check warning on line 420 in controllers/nutanixmachine_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

controllers/nutanixmachine_controller.go#L419-L420 

Added lines #L419 - L420 were not covered by tests

Check warning on line 423 in controllers/nutanixmachine_controller.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

controllers/nutanixmachine_controller.go#L423 

Added line #L423 was not covered by tests
View more details on Codecov