Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(controller): Move v4 client instantiation to reconcileDelete #465

Merged
merged 6 commits into from
Jul 31, 2024

fix lint issues

68e55a6
Select commit
Loading
Failed to load commit list.
Merged

fix(controller): Move v4 client instantiation to reconcileDelete #465

fix lint issues
68e55a6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jul 31, 2024 in 0s

31.14% (+1.80%) compared to fb76b4f

View this Pull Request on Codecov

31.14% (+1.80%) compared to fb76b4f

Details

Codecov Report

Attention: Patch coverage is 7.81250% with 59 lines in your changes missing coverage. Please review.

Project coverage is 31.14%. Comparing base (fb76b4f) to head (68e55a6).

Files Patch % Lines
controllers/nutanixmachine_controller.go 7.81% 59 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #465      +/-   ##
==========================================
+ Coverage   29.33%   31.14%   +1.80%     
==========================================
  Files          14       14              
  Lines        1476     1477       +1     
==========================================
+ Hits          433      460      +27     
+ Misses       1043     1017      -26     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.