-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Kmeans
timeouts issue on GPU for sparse inputs
#2906
Merged
ethanglaser
merged 1 commit into
oneapi-src:main
from
samir-nasibli:fix/kmeans_timeouts_sparse
Sep 19, 2024
Merged
FIX: Kmeans
timeouts issue on GPU for sparse inputs
#2906
ethanglaser
merged 1 commit into
oneapi-src:main
from
samir-nasibli:fix/kmeans_timeouts_sparse
Sep 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samir-nasibli
requested review from
Alexsandruss and
Alexandr-Solovev
as code owners
September 19, 2024 17:46
CI run: http://intel-ci.intel.com/ef76bc82-846a-f1a5-918c-a4bf010d0e2d -infra issues for WIN |
samir-nasibli
requested review from
icfaust,
maria-Petrova,
ethanglaser and
md-shafiul-alam
September 19, 2024 17:51
Closed
10 tasks
ethanglaser
approved these changes
Sep 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice work
@mergify backport rls/2025.0.0-rls |
✅ Backports have been created
|
10 tasks
maria-Petrova
pushed a commit
that referenced
this pull request
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Migration to the new icx compiler from icc caused timeouts for Kmeans sparse GPU inputs.
Issue was in the kernel
oneDAL/cpp/oneapi/dal/algo/kmeans/backend/gpu/kernels_csr_impl.hpp
Line 374 in b6b6a65