[EXP][CMDBUF] HIP adapter support for command buffers #1254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Liked DPC++ PR: intel/llvm#12230 |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #1254 +/- ##
==========================================
- Coverage 14.82% 12.54% -2.29%
==========================================
Files 250 239 -11
Lines 36220 35863 -357
Branches 4094 4067 -27
==========================================
- Hits 5369 4498 -871
- Misses 30800 31361 +561
+ Partials 51 4 -47 ☔ View full report in Codecov by Sentry. |
EwanC
approved these changes
Jan 17, 2024
jchlanda
reviewed
Jan 17, 2024
|
@jchlanda I've tried to address your comments as much as possible. Could you please take another look at this PR? |
jchlanda
approved these changes
Jan 25, 2024
EwanC
force-pushed
the
cmdbuf-support-hip
branch
from
90bd325
to
c9d1431
Compare
Command buffer functions for HIP. Some additional methods and refactoring to reuse existing adapter code. This code was mainly written by Andrey Alekseenko @al42and Co-authored-by: Andrey Alekseenko andrey.alekseenko@scilifelab.se Co-authored-by: Ewan Crawford <ewan@codeplay.com>
EwanC
force-pushed
the
cmdbuf-support-hip
branch
from
a0bebf1
to
f78d369
Compare
steffenlarsen
pushed a commit
to intel/llvm
that referenced
this pull request
Mar 1, 2024
Tests HIP Support for Graph from oneapi-src/unified-runtime#1254 and updates documentation. Depends on #12753. --------- Co-authored-by: Andrey Alekseenko <andrey.alekseenko@scilifelab.se> Co-authored-by: Ewan Crawford <ewan@codeplay.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
command buffer functions for HIP.
Some additional methods and refactoring to reuse existing adapter code.
(This code was mainly written by Andrey Alekseenko @al42and)
Co-authored-by: Andrey Alekseenko andrey.alekseenko@scilifelab.se