Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WRKLDS-1380: bump(github.com/openshift/api): DeploymentConfig: drop capability fro… #1066

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

WRKLDS-1380: bump(github.com/openshift/api): DeploymentConfig: drop capability fro… #1066

wants to merge 1 commit into from

Conversation

ingvagabund
Copy link
Member

…m the enabled-by-default set

To validate openshift/api#1954

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 10, 2024
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jul 10, 2024 •
edited by openshift-ci bot
Loading

@ingvagabund: This pull request references WRKLDS-1380 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to this:

…m the enabled-by-default set

To validate openshift/api#1954

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from DavidHurta and wking July 10, 2024 10:30
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ingvagabund
Once this PR has been reviewed and has the lgtm label, please assign petr-muller for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ingvagabund
Copy link
Member Author

/hold
Currently blocked by #1067, resp. #1045

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 10, 2024
@ingvagabund ingvagabund force-pushed the bump-deps-for-disabling-dc-cap-by-default branch from 5995393 to 8d0c2df Compare July 12, 2024 07:40
@ingvagabund
Copy link
Member Author

/retest

@ingvagabund
Copy link
Member Author

/retest-required

@ingvagabund
Copy link
Member Author

/retest

@ingvagabund
Copy link
Member Author

/retest-required

@ingvagabund
Copy link
Member Author

https://github.com/openshift/origin/blob/master/test/extended/util/client.go#L353-L357:

// Wait for SAs and default dockercfg Secret to be injected
	// TODO: it would be nice to have a shared list but it is defined in at least 3 place,
	// TODO: some of them not even using the constants
	DefaultServiceAccounts := []string{
		"default",
		"deployer",
		"builder",
	}

needs to be updated to ignore deployer SA when the capability is disabled.

@ingvagabund ingvagabund mentioned this pull request Jul 18, 2024
Merged
@ingvagabund
Copy link
Member Author

/retest-required

@ingvagabund ingvagabund mentioned this pull request Jul 22, 2024
Merged
@ingvagabund
Copy link
Member Author

/retest-required

1 similar comment
@ingvagabund
Copy link
Member Author

/retest-required

@ingvagabund ingvagabund force-pushed the bump-deps-for-disabling-dc-cap-by-default branch 2 times, most recently from f5eef7d to e739651 Compare July 24, 2024 18:33
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 25, 2024

@ingvagabund: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test e2e-agnostic-operator
  • /test e2e-agnostic-ovn
  • /test e2e-agnostic-ovn-upgrade-into-change
  • /test e2e-agnostic-ovn-upgrade-out-of-change
  • /test e2e-aws-ovn-techpreview
  • /test e2e-hypershift
  • /test e2e-hypershift-conformance
  • /test gofmt
  • /test images
  • /test lint
  • /test unit

The following commands are available to trigger optional jobs:

  • /test okd-scos-images

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-cluster-version-operator-master-e2e-agnostic-operator
  • pull-ci-openshift-cluster-version-operator-master-e2e-agnostic-ovn
  • pull-ci-openshift-cluster-version-operator-master-e2e-agnostic-ovn-upgrade-into-change
  • pull-ci-openshift-cluster-version-operator-master-e2e-agnostic-ovn-upgrade-out-of-change
  • pull-ci-openshift-cluster-version-operator-master-e2e-aws-ovn-techpreview
  • pull-ci-openshift-cluster-version-operator-master-e2e-hypershift
  • pull-ci-openshift-cluster-version-operator-master-e2e-hypershift-conformance
  • pull-ci-openshift-cluster-version-operator-master-gofmt
  • pull-ci-openshift-cluster-version-operator-master-images
  • pull-ci-openshift-cluster-version-operator-master-lint
  • pull-ci-openshift-cluster-version-operator-master-unit

In response to this:

/retest ci/prow/e2e-hypershift

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ingvagabund
Copy link
Member Author

/test e2e-hypershift

This was referenced Jul 25, 2024
Merged
Merged
Merged
@petr-muller
Copy link
Member

/retest

@ingvagabund ingvagabund force-pushed the bump-deps-for-disabling-dc-cap-by-default branch from e739651 to afc1d88 Compare July 25, 2024 12:12
@ingvagabund
Copy link
Member Author

/retest-required

2 similar comments
@ingvagabund
Copy link
Member Author

/retest-required

@ingvagabund
Copy link
Member Author

/retest-required

@ingvagabund
Copy link
Member Author

/retest-required

1 similar comment
@ingvagabund
Copy link
Member Author

/retest-required

@ingvagabund ingvagabund mentioned this pull request Jul 26, 2024
Open
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jul 26, 2024

@ingvagabund: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ingvagabund
Copy link
Member Author

I still need to wait until openshift/api#1954 merges so I can rebase this PR and ask for review.

@ingvagabund ingvagabund mentioned this pull request Sep 13, 2024
Merged
@ingvagabund ingvagabund force-pushed the bump-deps-for-disabling-dc-cap-by-default branch from afc1d88 to 64d6980 Compare October 14, 2024 12:41
@ingvagabund
Copy link
Member Author

ingvagabund commented Oct 14, 2024 •
edited
Loading

Running per openshift/origin#28957 (comment):

/payload 4.18 nightly blocking

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 14, 2024

@ingvagabund: trigger 14 job(s) of type blocking for the nightly release of OCP 4.18

  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-upgrade-ovn-single-node
  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-techpreview
  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.18-fips-payload-scan
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-ipv6
  • periodic-ci-openshift-microshift-release-4.18-periodics-e2e-aws-ovn-ocp-conformance
  • periodic-ci-openshift-microshift-release-4.18-periodics-e2e-aws-ovn-ocp-conformance-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ececaa40-8a29-11ef-871e-8ffa5499a06b-0

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Oct 14, 2024

@ingvagabund: trigger 14 job(s) of type blocking for the nightly release of OCP 4.18

  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-upgrade-ovn-single-node
  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.18-upgrade-from-stable-4.17-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.18-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-techpreview
  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-upgrade
  • periodic-ci-openshift-release-master-nightly-4.18-fips-payload-scan
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-master-nightly-4.18-e2e-metal-ipi-ovn-ipv6
  • periodic-ci-openshift-microshift-release-4.18-periodics-e2e-aws-ovn-ocp-conformance
  • periodic-ci-openshift-microshift-release-4.18-periodics-e2e-aws-ovn-ocp-conformance-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/1110ade0-8a2a-11ef-9875-38b1e64f7eb0-0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavidHurta DavidHurta Awaiting requested review from DavidHurta

@wking wking Awaiting requested review from wking

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ingvagabund @openshift-ci-robot @petr-muller