Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use SKBUILD_BUILD_VERBOSE instead of SKBUILD_CMAKE_VERBOSE #377

Merged
merged 2 commits into from
Aug 7, 2024

Conversation

jameslamb
Copy link
Member

@jameslamb jameslamb commented Aug 6, 2024

Proposes switching from SKBUILD_CMAKE_VERBOSE to SKBUILD_BUILD_VERBOSE in wheel-building scripts in rapids-build-utils.

Setting SKBUILD_CMAKE_VERBOSE in the environment causes an unavoidable build-time exception when using scikit-build-core>=0.10.0 and setting minimum-version = "0.10.0" in scikit-build-core.

ERROR: Cannot set cmake.verbose if minimum-version is set to 0.10 or higher

(build link)

See https://scikit-build-core.readthedocs.io/en/latest/configuration.html#verbosity

Changed in version 0.10: cmake.verbose was renamed to build.verbose.

Notes for Reviewers

For more context, see the conversation on that PR and rapidsai/build-planning#58.

@jakirkham
Copy link
Member

Looks like the CI failures here are the same ones already seen with scikit-build-core

xref: rapidsai/rmm#1638 (comment)

@jameslamb
Copy link
Member Author

Looks like the CI failures here are the same ones already seen with scikit-build-core

I just restarted CI, now that there's a v0.10.1 of scikit-build-core up on PyPI and conda-forge which RAPIDS 24.08 builds successfully with:

I'm going to move this back to draft, let's not merge it yet. If those builds end up succeeding without any changes to any RAPIDS libraries, then that means we could target this at branch-24.10 instead.

Will check back in the morning.

@jameslamb jameslamb changed the title use SKBUILD_BUILD_VERBOSE instead of SKBUILD_CMAKE_VERBOSE WIP: [DO NOT MERGE] use SKBUILD_BUILD_VERBOSE instead of SKBUILD_CMAKE_VERBOSE Aug 7, 2024
@jameslamb jameslamb added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Aug 7, 2024
@jameslamb jameslamb marked this pull request as draft August 7, 2024 03:07
@jameslamb jameslamb changed the base branch from branch-24.08 to branch-24.10 August 7, 2024 14:05
@jakirkham
Copy link
Member

/merge

@jameslamb
Copy link
Member Author

/merge

@trxcllnt trxcllnt merged commit f27d9f6 into rapidsai:branch-24.10 Aug 7, 2024
26 checks passed
@jameslamb jameslamb deleted the cmake-verbose branch August 7, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants