Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webui fix clicking on current step #5084

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Webui fix clicking on current step #5084

merged 2 commits into from
Aug 29, 2023

Conversation

rvykydal
Copy link
Contributor

@rvykydal
Copy link
Contributor Author

/kickstart-test --waive webui-only

VladimirSlavik
VladimirSlavik approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@VladimirSlavik VladimirSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM except for minor details.

I'd also expect the commits in reverse order, but it's not too important.

ui/webui/test/check-basic Outdated Show resolved Hide resolved
ui/webui/test/check-basic Show resolved Hide resolved
@rvykydal rvykydal force-pushed the webui-fix-clicking-on-current-step branch from 8b21ce4 to 3d3d0eb Compare August 28, 2023 14:06
@rvykydal rvykydal force-pushed the webui-fix-clicking-on-current-step branch from 3d3d0eb to bcd5b57 Compare August 28, 2023 14:09
@rvykydal rvykydal requested a review from M4rtinK August 28, 2023 14:10
@jkonecny12 jkonecny12 mentioned this pull request Aug 29, 2023
Closed
M4rtinK
M4rtinK approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. :)

@rvykydal
Copy link
Contributor Author

/kickstart-test --waive webui-only

@rvykydal rvykydal merged commit 0ef81cf into rhinstaller:master Aug 29, 2023
14 checks passed
@M4rtinK M4rtinK mentioned this pull request Aug 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirSlavik VladimirSlavik VladimirSlavik approved these changes

@M4rtinK M4rtinK M4rtinK approved these changes

Assignees
No one assigned
Labels
f39 webui
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rvykydal @M4rtinK @VladimirSlavik