Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove N extension (user mode interrupts) #531

Closed
wants to merge 0 commits into from

Conversation

KotorinMinami
Copy link
Contributor

Since the RISC-V N extension draft was removed in the priv spec 1.2 version, the CSR sedeleg is also not listed in the CSR table in the spec. Therefore, it should be removed.

By the way, the implementation of the N extension in the master branch of Sail might be redundant or confusing and lack rigor. I believe it may need to be removed or moved to another branch.

Copy link

github-actions bot commented Aug 29, 2024

Test Results

712 tests  ±0   712 ✅ ±0   0s ⏱️ ±0s
  6 suites ±0     0 💤 ±0 
  1 files   ±0     0 ❌ ±0 

Results for commit d79e0ba. ± Comparison against base commit c61351e.

♻️ This comment has been updated with latest results.

@Timmmm
Copy link
Collaborator

Timmmm commented Aug 30, 2024

Seems to inconsistently remove sedeleg and sideleg. And why only remove those aspects of the N extension? Either remove the entire N extension or none of it surely?

@arichardson
Copy link
Collaborator

Seems to inconsistently remove sedeleg and sideleg. And why only remove those aspects of the N extension? Either remove the entire N extension or none of it surely?

Agreed, I think it would make more sense to completely remove the N extension support. I don't believe this was ever used?

@Timmmm Timmmm changed the title remove non-existent CSR sedeleg Remove N extension (user mode interrupts) Sep 13, 2024
@KotorinMinami
Copy link
Contributor Author

@Timmmm Of course I would like to remove the entire N extension. However, some matters have been occupying my time, and due to some unresolved issues in the execution flow of SAIL and in the privileged level interrupt permissions, I haven't been able to complete the work until now. It may be finished at the moment. Could you please spend a convenient time to review my code?

@Timmmm Timmmm self-requested a review September 30, 2024 15:07
Timmmm pushed a commit to Timmmm/sail-riscv that referenced this pull request Oct 2, 2024
 improvements to debug tests infrastructure to help with triaging process
@Timmmm Timmmm closed this Oct 9, 2024
@Timmmm
Copy link
Collaborator

Timmmm commented Oct 9, 2024

Err sorry, I didn't mean to close this, but Git didn't do what I expect - apparently if you do git push -f KotorinMinami master it will push master to KotorinMinami/master even if you are on a different branch. I should have done git push -f KotorinMinami HEAD:master. Who knew.

Unfortunately now Github thinks your master branch isn't a PR so it won't let me push to it. I'll open a new PR... sorry about that!

@Timmmm Timmmm mentioned this pull request Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants