Empty urdf tag humble (backport of #1017) #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
anfemosa,
arne48,
bmagyar,
destogl,
jaron-l,
mhubii and
peterdavidfagan
* Do not explode with empty tag * Update tests to allow empty URDF parameter to hardware interface * Test checks that empty parameter tags work and actually checks the parsed urdf. --------- Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com> Co-authored-by: Dr. Denis <denis@stoglrobotics.de> (cherry picked from commit 7c07430) # Conflicts: # hardware_interface/src/component_parser.cpp
fmauch
force-pushed
the
empty_urdf_tag_humble
branch
from
411a7f2
to
d7ac100
Compare
bmagyar
approved these changes
May 28, 2023
arne48
approved these changes
May 28, 2023
flochre
pushed a commit
to flochre/ros2_control
that referenced
this pull request
Jul 5, 2023
) * [URDF Parser] Allow empty urdf tag, e.g., parameter (ros-controls#1017) * Do not explode with empty tag * Update tests to allow empty URDF parameter to hardware interface * Test checks that empty parameter tags work and actually checks the parsed urdf. * Patch test updates for humble API --------- Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com> Co-authored-by: Dr. Denis <denis@stoglrobotics.de> (cherry picked from commit 7c07430)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of #1017 replacing #1030, since that a) has merge conflicts due to a failed mergify backport and b) does not build on humble due to a different API.