Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure instantiation of hardware classes work for python bindings #1058

Merged
merged 4 commits into from
Jun 21, 2023
Merged

Ensure instantiation of hardware classes work for python bindings #1058

merged 4 commits into from
Jun 21, 2023

Conversation

olivier-stasse
Copy link
Contributor

This PR fixes #1057 by adding a default constructor to System

@bmagyar bmagyar changed the title Debug instanciation of hardware Ensure instantiation of hardware classes work for python bindings Jun 20, 2023
bmagyar
bmagyar previously approved these changes Jun 20, 2023
View reviewed changes
Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bmagyar bmagyar enabled auto-merge (squash) June 20, 2023 20:21
@codecov-commenter
Copy link

codecov-commenter commented Jun 20, 2023 •
edited
Loading

Codecov Report

Merging #1058 (504a8ae) into master (925f5f3) will decrease coverage by 2.23%.
The diff coverage is 35.14%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##           master    #1058      +/-   ##
==========================================
- Coverage   34.61%   32.39%   -2.23%     
==========================================
  Files          52       94      +42     
  Lines        2981     9799    +6818     
  Branches     1855     6599    +4744     
==========================================
+ Hits         1032     3174    +2142     
- Misses        310      777     +467     
- Partials     1639     5848    +4209
Flag Coverage Δ
unittests 32.39% <35.14%> (-2.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controller_manager/src/controller_manager.cpp 38.04% <ø> (-1.67%) ⬇️
controller_manager/src/ros2_control_node.cpp 0.00% <0.00%> (ø)
..._interface/include/hardware_interface/actuator.hpp 100.00% <ø> (ø)
...ce/include/hardware_interface/async_components.hpp 0.00% <0.00%> (ø)
...re_interface/include/hardware_interface/sensor.hpp 100.00% <ø> (ø)
...re_interface/include/hardware_interface/system.hpp 100.00% <ø> (ø)
hardware_interface/src/resource_manager.cpp 47.32% <ø> (-6.30%) ⬇️
hardware_interface/src/sensor.cpp 50.52% <ø> (ø)
hardware_interface/src/system.cpp 55.45% <ø> (ø)
...rface/test/mock_components/test_generic_system.cpp 9.42% <ø> (ø)
... and 71 more

... and 19 files with indirect coverage changes

@bmagyar bmagyar disabled auto-merge June 21, 2023 07:34
@bmagyar bmagyar merged commit db34dfa into ros-controls:master Jun 21, 2023
1 check passed
@bmagyar bmagyar added the backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. label Jun 21, 2023
@bmagyar
Copy link
Member

bmagyar commented Jun 21, 2023

@Mergifyio backport humble

@mergify
Copy link
Contributor

mergify bot commented Jun 21, 2023 •
edited
Loading

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jun 21, 2023
@olivier-stasse @mergify
Ensure instantiation of hardware classes work for python bindings (#1058
ed42674 
)

(cherry picked from commit db34dfa)
@mergify mergify bot mentioned this pull request Jun 21, 2023
Merged
@olivier-stasse
Copy link
Contributor Author

Thanks !

bmagyar pushed a commit that referenced this pull request Jun 21, 2023
@mergify @olivier-stasse
Ensure instantiation of hardware classes work for python bindings (#1058
0dfe01a 
) (#1062)

(cherry picked from commit db34dfa)

Co-authored-by: Olivier Stasse <ostasse@laas.fr>
flochre pushed a commit to flochre/ros2_control that referenced this pull request Jul 5, 2023
@mergify @olivier-stasse @flochre
Ensure instantiation of hardware classes work for python bindings (ro…
3470e0b 
…s-controls#1058) (ros-controls#1062)

(cherry picked from commit db34dfa)

Co-authored-by: Olivier Stasse <ostasse@laas.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikishor saikishor saikishor approved these changes

@bmagyar bmagyar bmagyar approved these changes

@christophfroehlich christophfroehlich christophfroehlich approved these changes

@destogl destogl Awaiting requested review from destogl

@jaron-l jaron-l Awaiting requested review from jaron-l

@livanov93 livanov93 Awaiting requested review from livanov93

@mcbed mcbed Awaiting requested review from mcbed

@rosterloh rosterloh Awaiting requested review from rosterloh

Assignees
No one assigned
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble.
Projects
Bugs & Bugfixes
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No System() = default constructor
5 participants
@olivier-stasse @codecov-commenter @bmagyar @christophfroehlich @saikishor