Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CM] Use explicit constants in controller tests. #1356

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

destogl
Copy link
Member

@destogl destogl commented Feb 1, 2024

No description provided.

@destogl destogl added enhancement backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. labels Feb 1, 2024
@destogl destogl self-assigned this Feb 1, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5b5f332) 47.53% compared to head (2a50266) 47.53%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1356   +/-   ##
=======================================
  Coverage   47.53%   47.53%           
=======================================
  Files          41       41           
  Lines        3549     3549           
  Branches     1931     1931           
=======================================
  Hits         1687     1687           
  Misses        459      459           
  Partials     1403     1403           
Flag Coverage Δ
unittests 47.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look clean and minimal.
Thanks for the changes!

@destogl destogl merged commit cac7272 into master Feb 1, 2024
16 of 17 checks passed
mergify bot pushed a commit that referenced this pull request Feb 1, 2024
mergify bot pushed a commit that referenced this pull request Feb 1, 2024
@christophfroehlich christophfroehlich deleted the cm-controller-tests-more-readable branch March 3, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants