Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -Werror=missing-braces to compile options #1423

Merged
merged 3 commits into from
Mar 2, 2024

Conversation

saikishor
Copy link
Member

Small change by extending the compiler flags

@saikishor saikishor marked this pull request as ready for review February 29, 2024 10:38
Copy link

codecov bot commented Feb 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.59%. Comparing base (69e5e27) to head (d3584ed).

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #1423       +/-   ##
===========================================
+ Coverage        0   47.59%   +47.59%     
===========================================
  Files           0       41       +41     
  Lines           0     3553     +3553     
  Branches        0     1932     +1932     
===========================================
+ Hits            0     1691     +1691     
- Misses          0      460      +460     
- Partials        0     1402     +1402     
Flag Coverage Δ
unittests 47.59% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 41 files with indirect coverage changes

Copy link
Member

@bmagyar bmagyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have any good reference for why it's encouraged to "write correct code"?

@saikishor
Copy link
Member Author

Do you have any good reference for why it's encouraged to "write correct code"?

Nope!
I don't have any references in hand right now 😅

@bmagyar bmagyar merged commit a7af60b into ros-controls:master Mar 2, 2024
13 checks passed
@saikishor saikishor deleted the add/missing-braces/flag branch August 17, 2024 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants