Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GenericSystem: Add missing calculate_dynamics to docs #1498

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

christophfroehlich
Copy link
Contributor

calculate_dynamics was implemented with #1028 but not added to the docs. I also added a sample config and links to the examples.

image

@christophfroehlich christophfroehlich added backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. labels Apr 22, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.67%. Comparing base (16fbde3) to head (a215d23).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1498   +/-   ##
=======================================
  Coverage   62.67%   62.67%           
=======================================
  Files          96       96           
  Lines       11311    11311           
  Branches     8151     8151           
=======================================
  Hits         7089     7089           
  Misses        715      715           
  Partials     3507     3507           
Flag Coverage Δ
unittests 62.67% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christophfroehlich christophfroehlich merged commit 6e7a072 into master Apr 29, 2024
12 of 13 checks passed
@christophfroehlich christophfroehlich deleted the doc_mock_hardware branch April 29, 2024 12:55
mergify bot pushed a commit that referenced this pull request Apr 29, 2024
(cherry picked from commit 6e7a072)

# Conflicts:
#	hardware_interface/doc/mock_components_userdoc.rst
mergify bot pushed a commit that referenced this pull request Apr 29, 2024
(cherry picked from commit 6e7a072)

# Conflicts:
#	hardware_interface/doc/mock_components_userdoc.rst
christophfroehlich added a commit that referenced this pull request Apr 29, 2024
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
christophfroehlich added a commit that referenced this pull request Apr 29, 2024
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants