-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fallback controllers list to the ControllerInfo #1503
Add fallback controllers list to the ControllerInfo #1503
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1503 +/- ##
=======================================
Coverage 88.42% 88.42%
=======================================
Files 101 101
Lines 8327 8349 +22
Branches 726 728 +2
=======================================
+ Hits 7363 7383 +20
Misses 703 703
- Partials 261 263 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
As discussed on 1st April Jazzy meeting, I've created the basic version of adding the fallback controllers list into the controller info and added tests to verify if it is parsing properly or not, we will later continue with the main feature.
This is done as a part of #1468
Better wait for #1502 to be merged first as it might have conflicts with this in the spawner.py (or vice versa)