Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fallback controllers list to the ControllerInfo #1503

Merged

Conversation

saikishor
Copy link
Member

@saikishor saikishor commented Apr 23, 2024

As discussed on 1st April Jazzy meeting, I've created the basic version of adding the fallback controllers list into the controller info and added tests to verify if it is parsing properly or not, we will later continue with the main feature.

This is done as a part of #1468

Better wait for #1502 to be merged first as it might have conflicts with this in the spawner.py (or vice versa)

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 88.42%. Comparing base (0112083) to head (acf764f).

❗ Current head acf764f differs from pull request most recent head 52078e8. Consider uploading reports for the commit 52078e8 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1503   +/-   ##
=======================================
  Coverage   88.42%   88.42%           
=======================================
  Files         101      101           
  Lines        8327     8349   +22     
  Branches      726      728    +2     
=======================================
+ Hits         7363     7383   +20     
  Misses        703      703           
- Partials      261      263    +2     
Flag Coverage Δ
unittests 88.42% <90.90%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
controller_manager/test/test_spawner_unspawner.cpp 99.00% <100.00%> (+0.18%) ⬆️
controller_manager/src/controller_manager.cpp 74.85% <66.66%> (-0.05%) ⬇️

bmagyar
bmagyar previously approved these changes May 4, 2024
@bmagyar bmagyar merged commit 7fdf472 into ros-controls:master May 4, 2024
8 of 11 checks passed
@saikishor saikishor deleted the add/fallback_controllers_list branch August 17, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants