Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependencies for source build (backport #1533) #1536

Merged
merged 1 commit into from
May 11, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 11, 2024

The source builds consistently fail with the following errors

   sh: 1: ros2: not found
  /__w/ros2_control/ros2_control/ros_ws/src/rna86ha94vo/ros2_control/controller_interface/test/test_controller_interface.cpp:91: Failure
  Expected equality of these values:
    std::system("ros2 param set /testable_controller_interface update_rate 623")
      Which is: 32512
    0

and

  launch_test.py: error: No module named 'launch_ros'

Both come from missing dependencies on ros2cli and launch_ros.

  • I don't think that std::system is necessary and changed this to set the parameter of the node via C++ API.
  • Added launch_ros to the test_dependency of joint_limits

Voilà


This is an automatic backport of pull request #1533 done by Mergify.

* Don't use std::system call inside test

* Give launch_ros as explicit dependency

* Test the source build on this branch

* Revert "Test the source build on this branch"

This reverts commit 9884b11.

(cherry picked from commit e260049)
Copy link

codecov bot commented May 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.45%. Comparing base (745ecba) to head (51ebe9b).

Additional details and impacted files
@@           Coverage Diff           @@
##             iron    #1536   +/-   ##
=======================================
  Coverage   87.45%   87.45%           
=======================================
  Files         101      101           
  Lines        8077     8078    +1     
  Branches      714      714           
=======================================
+ Hits         7064     7065    +1     
  Misses        717      717           
  Partials      296      296           
Flag Coverage Δ
unittests 87.45% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...oller_interface/test/test_controller_interface.cpp 100.00% <100.00%> (ø)

@christophfroehlich christophfroehlich merged commit 3c15819 into iron May 11, 2024
11 of 12 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/iron/pr-1533 branch May 11, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant