[ControllerInterface] Avoid warning about conversion from int64_t to unsigned int (backport #1173)
#1630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## iron #1630 +/- ##
=======================================
Coverage 87.45% 87.45%
=======================================
Files 101 101
Lines 8080 8080
Branches 711 711
=======================================
Hits 7066 7066
Misses 718 718
Partials 296 296
Flags with carried forward coverage won't be shown. Click here to find out more.
|
…o `unsigned int` (#1173) Without this there is a warning. For what I found the best way is to do static cast. ``` ros2_control/controller_interface/src/controller_interface_base.cpp:88:67: warning: conversion from ‘int64_t’{aka ‘long int’} to ‘unsigned int’ may change value [-Wconversion] 88 | update_rate_ = get_node()->get_parameter("update_rate").as_int(); ``` (cherry picked from commit 2569b76)
christophfroehlich
force-pushed
the
mergify/bp/iron/pr-1173
branch
from
1f16796
to
d026f0b
Compare
christophfroehlich
approved these changes
Jul 20, 2024
saikishor
approved these changes
Jul 21, 2024
olivier-stasse
approved these changes
Jul 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this there is a warning. For what I found the best way is to do static cast.
#GitHub-Programming-Rocks
This is an automatic backport of pull request #1173 done by Mergify.