Fix spawner tests timeout on source builds #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
aprotyas,
bmagyar,
DasRoteSkelett,
destogl,
fmauch,
livanov93 and
olivier-stasse
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1692 +/- ##
=======================================
Coverage 86.64% 86.64%
=======================================
Files 115 115
Lines 10542 10546 +4
Branches 970 970
=======================================
+ Hits 9134 9138 +4
Misses 1059 1059
Partials 349 349
Flags with carried forward coverage won't be shown. Click here to find out more.
|
olivier-stasse
approved these changes
Aug 17, 2024
christophfroehlich
approved these changes
Aug 18, 2024
bmagyar
approved these changes
Aug 19, 2024
bmagyar
added
backport-humble
mergify bot
pushed a commit
that referenced
this pull request
Aug 19, 2024
(cherry picked from commit 079392b) # Conflicts: # controller_manager/test/test_spawner_unspawner.cpp
mergify bot
pushed a commit
that referenced
this pull request
Aug 19, 2024
(cherry picked from commit 079392b) # Conflicts: # controller_manager/test/test_spawner_unspawner.cpp
This was referenced Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by @christophfroehlich in #1685, it seems that spawner tests are inconsistent and timing out after some time. I was able to reproduce it locally and upon checking it seems like the CM's internal mutexes are blcoking as there is no ControllerManagerRunner in some of these tests. Adding these should fix the above timeout issues. I've tested it locally and it seems to work
Fixes #1685