Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

propagate a portion of global args to the controller nodes for remapping to work #1712

Conversation

saikishor
Copy link
Member

@saikishor saikishor commented Aug 23, 2024

Fixes: #1711

@saikishor saikishor force-pushed the add/global_options/propagation branch from 30587eb to 7dc85a8 Compare August 23, 2024 09:18
Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 53.57143% with 13 lines in your changes missing coverage. Please review.

Project coverage is 86.73%. Comparing base (ecfec15) to head (7dc85a8).
Report is 1 commits behind head on master.

Files Patch % Lines
controller_manager/src/controller_manager.cpp 42.85% 11 Missing and 1 partial ⚠️
controller_manager/src/ros2_control_node.cpp 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1712      +/-   ##
==========================================
- Coverage   86.81%   86.73%   -0.09%     
==========================================
  Files         116      116              
  Lines       10600    10618      +18     
  Branches      975      978       +3     
==========================================
+ Hits         9202     9209       +7     
- Misses       1048     1058      +10     
- Partials      350      351       +1     
Flag Coverage Δ
unittests 86.73% <53.57%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../include/controller_manager/controller_manager.hpp 100.00% <ø> (ø)
controller_manager/src/ros2_control_node.cpp 88.23% <85.71%> (-1.06%) ⬇️
controller_manager/src/controller_manager.cpp 77.41% <42.85%> (-0.67%) ⬇️

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully tested with the demos, thanks for the quick fix!

@saikishor
Copy link
Member Author

This is one approach to address the issue: ros2/rclcpp#2610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remapping of topics via ros2_control_node is not possible any more
3 participants