-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
propagate a portion of global args to the controller nodes for remapping to work #1712
propagate a portion of global args to the controller nodes for remapping to work #1712
Conversation
30587eb
to
7dc85a8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1712 +/- ##
==========================================
- Coverage 86.81% 86.73% -0.09%
==========================================
Files 116 116
Lines 10600 10618 +18
Branches 975 978 +3
==========================================
+ Hits 9202 9209 +7
- Misses 1048 1058 +10
- Partials 350 351 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Successfully tested with the demos, thanks for the quick fix!
08492a1
into
ros-controls:master
This is one approach to address the issue: ros2/rclcpp#2610 |
Fixes: #1711