[CM] Throw an exception when the components initially fail to be in the required state #1729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
aprotyas,
bijoua29,
bmagyar,
christophfroehlich,
destogl,
moriarty and
peterdavidfagan
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1729 +/- ##
==========================================
- Coverage 86.77% 86.74% -0.03%
==========================================
Files 116 116
Lines 10703 10709 +6
Branches 981 981
==========================================
+ Hits 9288 9290 +2
- Misses 1062 1066 +4
Partials 353 353
Flags with carried forward coverage won't be shown. Click here to find out more.
|
christophfroehlich
added
backport-humble
bmagyar
reviewed
Aug 30, 2024
bmagyar
requested changes
Aug 30, 2024
|
Also... would a test for this be possible? |
Yes! I'll add it when I address #1530. It's in my list. I wanted to do it once the variants and others are merged. |
|
Thank you @christophfroehlich @bmagyar |
christophfroehlich
approved these changes
Aug 30, 2024
Co-authored-by: Bence Magyar <bence.magyar.robotics@gmail.com>
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
saikishor
force-pushed
the
throw_when_failed_configuring
branch
from
155a5b7
to
51372f8
Compare
bmagyar
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We faced another bug during our testing when the HW component failed to configure at the beginning, the CM prints that the Resource Manager is successfully initialized and exposes it's internal services and the spawner calls are being processed on startup.
I believe, If the user's initial intent is supposed to be in a particular state, it is better to have failed when this is not the case rather than continue to expose services and then fail again. Usually, when the services are exposed, it is expected that HW components are successfully initialized.