Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CM] Handle other exceptions while loading the controller plugin #1731

Conversation

saikishor
Copy link
Member

As of now, we are only handling the exceptions of the pluginlib::CreateClassException there are many other exceptions defined by the pluginlib, that might be also interesting to catch. I'm using std::exception as the main PluginlibException is derived from std::runtime_error and which is derived from std::exception, and this gives us way to be generic (https://github.com/ros/pluginlib/blob/jazzy/pluginlib/include/pluginlib/exceptions.hpp#L43)

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 86.79%. Comparing base (f743bf4) to head (544f693).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
controller_manager/src/controller_manager.cpp 0.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1731      +/-   ##
==========================================
- Coverage   86.82%   86.79%   -0.03%     
==========================================
  Files         116      116              
  Lines       10701    10704       +3     
  Branches      979      979              
==========================================
  Hits         9291     9291              
- Misses       1059     1062       +3     
  Partials      351      351              
Flag Coverage Δ
unittests 86.79% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
controller_manager/src/controller_manager.cpp 77.47% <0.00%> (-0.21%) ⬇️

@christophfroehlich christophfroehlich added backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron. labels Aug 29, 2024
@bmagyar bmagyar merged commit 045b060 into ros-controls:master Aug 30, 2024
19 checks passed
@bmagyar bmagyar deleted the fix/pluginlib/exception_handling branch August 30, 2024 15:49
mergify bot pushed a commit that referenced this pull request Aug 30, 2024
mergify bot pushed a commit that referenced this pull request Aug 30, 2024
christophfroehlich pushed a commit that referenced this pull request Aug 30, 2024
christophfroehlich pushed a commit that referenced this pull request Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintaines only! Label triggers PR backport to ROS2 humble. backport-iron This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants