-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CM] Handle other exceptions while loading the controller plugin #1731
Merged
bmagyar
merged 2 commits into
ros-controls:master
from
pal-robotics-forks:fix/pluginlib/exception_handling
Aug 30, 2024
Merged
[CM] Handle other exceptions while loading the controller plugin #1731
bmagyar
merged 2 commits into
ros-controls:master
from
pal-robotics-forks:fix/pluginlib/exception_handling
Aug 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bmagyar,
DasRoteSkelett,
destogl,
erickisos,
fmauch,
mcbed and
VanshGehlot
August 29, 2024 07:47
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1731 +/- ##
==========================================
- Coverage 86.82% 86.79% -0.03%
==========================================
Files 116 116
Lines 10701 10704 +3
Branches 979 979
==========================================
Hits 9291 9291
- Misses 1059 1062 +3
Partials 351 351
Flags with carried forward coverage won't be shown. Click here to find out more.
|
christophfroehlich
previously approved these changes
Aug 29, 2024
christophfroehlich
added
backport-humble
This label should be used by maintaines only! Label triggers PR backport to ROS2 humble.
backport-iron
This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
labels
Aug 29, 2024
bmagyar
requested changes
Aug 29, 2024
saikishor
commented
Aug 29, 2024
bmagyar
approved these changes
Aug 30, 2024
mergify bot
pushed a commit
that referenced
this pull request
Aug 30, 2024
(cherry picked from commit 045b060)
mergify bot
pushed a commit
that referenced
this pull request
Aug 30, 2024
(cherry picked from commit 045b060)
This was referenced Aug 30, 2024
christophfroehlich
pushed a commit
that referenced
this pull request
Aug 30, 2024
(cherry picked from commit 045b060)
christophfroehlich
pushed a commit
that referenced
this pull request
Aug 30, 2024
(cherry picked from commit 045b060)
bmagyar
pushed a commit
that referenced
this pull request
Oct 10, 2024
bmagyar
pushed a commit
that referenced
this pull request
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport-humble
This label should be used by maintaines only! Label triggers PR backport to ROS2 humble.
backport-iron
This label should be used by maintaines only! Label triggers PR backport to ROS2 Iron.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of now, we are only handling the exceptions of the
pluginlib::CreateClassException
there are many other exceptions defined by the pluginlib, that might be also interesting to catch. I'm using std::exception as the main PluginlibException is derived from std::runtime_error and which is derived from std::exception, and this gives us way to be generic (https://github.com/ros/pluginlib/blob/jazzy/pluginlib/include/pluginlib/exceptions.hpp#L43)