-
Notifications
You must be signed in to change notification settings - Fork 304
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: typo use thread_priority #1844
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the catch !
LGTM
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1844 +/- ##
=======================================
Coverage 88.25% 88.26%
=======================================
Files 121 121
Lines 12301 12301
Branches 1093 1093
=======================================
+ Hits 10856 10857 +1
Misses 1051 1051
+ Partials 394 393 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@Mergifyio backport iron humble |
✅ Backports have been created
|
(cherry picked from commit be0a339) # Conflicts: # controller_manager/src/ros2_control_node.cpp
(cherry picked from commit be0a339) # Conflicts: # controller_manager/src/ros2_control_node.cpp
Fixed typo with the logs with the thread priority usage. Use the user set parameter thread priority rather than default
kSchedPriority
. If user doesn't set the thread_priority it will be defaulted to the kSchedPriority.