Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo use thread_priority #1844

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

BarisYazici
Copy link
Contributor

Fixed typo with the logs with the thread priority usage. Use the user set parameter thread priority rather than default kSchedPriority. If user doesn't set the thread_priority it will be defaulted to the kSchedPriority.

Copy link
Contributor

@olivier-stasse olivier-stasse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch !
LGTM

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.26%. Comparing base (5dbd6d5) to head (02040fb).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1844   +/-   ##
=======================================
  Coverage   88.25%   88.26%           
=======================================
  Files         121      121           
  Lines       12301    12301           
  Branches     1093     1093           
=======================================
+ Hits        10856    10857    +1     
  Misses       1051     1051           
+ Partials      394      393    -1     
Flag Coverage Δ
unittests 88.26% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
controller_manager/src/ros2_control_node.cpp 88.57% <ø> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@christophfroehlich christophfroehlich merged commit be0a339 into ros-controls:master Nov 4, 2024
20 checks passed
@christophfroehlich
Copy link
Contributor

@Mergifyio backport iron humble

Copy link
Contributor

mergify bot commented Nov 4, 2024

backport iron humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Nov 4, 2024
(cherry picked from commit be0a339)

# Conflicts:
#	controller_manager/src/ros2_control_node.cpp
mergify bot pushed a commit that referenced this pull request Nov 4, 2024
(cherry picked from commit be0a339)

# Conflicts:
#	controller_manager/src/ros2_control_node.cpp
saikishor pushed a commit to pal-robotics-forks/ros2_control that referenced this pull request Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants