Add Saturation Joint Limiter that uses clamping method #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added initial structures for joint-limit plugins. - Correct ruckig name and make tests to work. - Rename the joint_limits package - Comment and author cleanup - Base class does not require libary. - Delete extra layer of abstraction since not all plugins require a vector of smoothing objects. - Restore simple_joint_limiter to a working state - Implement init() and enforce() - Return of joint_limits package. - Move Ruckig limiter to package joint_limits_enforcement_plugins and make it working.
Debug and optimize Rucking JointLimiter.
…r) (#6) * Merge error handling possilibity on read and write. * Ros2 control extensions rolling joint limits plugins (#5) * Added initial structures for joint-limit plugins. * Move Ruckig limiter to package joint_limits_enforcement_plugins and make it working. Co-authored-by: AndyZe <zelenak@picknik.ai> * Add option to automatically update parameters after getting them from parameter server. * Modify simple joint limiting plugin (same as changes to moveit2 filter) * Add backward_ros dependency for crash stack trace * Check for required inputs in simple joint limiter * Change services history QOS to 'keep all' so client req are not dropped * Add missing on 'pluginlib' dependency explicitly. * Update ControllerParameters structure to support custom prefix and use in filters. * Update messge. * Change controller param changed msg log level to info instead of error --------- Co-authored-by: Denis Štogl <destogl@users.noreply.github.com> Co-authored-by: AndyZe <zelenak@picknik.ai> Co-authored-by: bijoua <bijou.abraham@technipfmc.com> Co-authored-by: bijoua29 <73511637+bijoua29@users.noreply.github.com>
github-actions
bot
requested review from
anfemosa,
bmagyar,
duringhof,
harderthan,
homalozoa and
livanov93
|
This pull request is in conflict. Could you fix it @destogl? |
|
This pull request is in conflict. Could you fix it @destogl? |
AndyZe
reviewed
Mar 17, 2023
hardware_interface/include/hardware_interface/types/hardware_interface_type_values.hpp
Outdated
Show resolved
Hide resolved
|
@destogl please consider this comment: #977 (review) |
|
This pull request is in conflict. Could you fix it @destogl? |
destogl
commented
Apr 13, 2023
destogl
commented
Apr 13, 2023
destogl
commented
Apr 13, 2023
destogl
commented
Apr 13, 2023
hardware_interface/include/hardware_interface/types/hardware_interface_type_values.hpp
Outdated
Show resolved
Hide resolved
destogl
commented
Apr 13, 2023
destogl
commented
Feb 8, 2024
|
This pull request is in conflict. Could you fix it @destogl? |
|
This pull request is in conflict. Could you fix it @destogl? |
muritane
added a commit
to StoglRobotics-forks/ros2_control
that referenced
this pull request
Jun 13, 2024
bmagyar
requested changes
Jul 3, 2024
Comment on lines
+17
to
+21
| #include "joint_limits/joint_limiter_interface.hpp" | ||
|
|
||
| namespace joint_limits | ||
| { | ||
| } // namespace joint_limits |
There was a problem hiding this comment.
I will test this one more time and explain way.
There was a problem hiding this comment.
OK, we are required to have this .cppfile as this is a base interface for pluginlib. I have added the full implementation to .hpp because of templated class, as the exact methods are generated on the compile time.
bmagyar
previously approved these changes
Jul 3, 2024
destogl
commented
Jul 3, 2024
destogl
commented
Jul 3, 2024
destogl
commented
Jul 3, 2024
destogl
commented
Jul 3, 2024
destogl
commented
Jul 3, 2024
destogl
commented
Jul 3, 2024
destogl
commented
Jul 3, 2024
|
Merging as agreed in WG Meeting yesterday. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add basic interface for joint limiting plugins and simple joint limiter that can always be used and it is installed per default.