Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for missing hardware interfaces that use the gpio tag. #975

Merged
merged 1 commit into from
Mar 20, 2023

Conversation

bmagyar
Copy link
Member

@bmagyar bmagyar commented Mar 20, 2023

Forward port of #953

@codecov-commenter
Copy link

Codecov Report

Merging #975 (3dbb1ec) into master (925f5f3) will decrease coverage by 1.82%.
The diff coverage is 35.84%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #975      +/-   ##
==========================================
- Coverage   34.61%   32.80%   -1.82%     
==========================================
  Files          52       91      +39     
  Lines        2981     9518    +6537     
  Branches     1855     6415    +4560     
==========================================
+ Hits         1032     3122    +2090     
- Misses        310      676     +366     
- Partials     1639     5720    +4081     
Flag Coverage Δ
unittests 32.80% <35.84%> (-1.82%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
controller_manager/src/controller_manager.cpp 38.61% <ø> (-1.10%) ⬇️
controller_manager/src/ros2_control_node.cpp 0.00% <0.00%> (ø)
..._interface/include/hardware_interface/actuator.hpp 100.00% <ø> (ø)
...re_interface/include/hardware_interface/sensor.hpp 100.00% <ø> (ø)
...re_interface/include/hardware_interface/system.hpp 100.00% <ø> (ø)
hardware_interface/src/resource_manager.cpp 49.91% <ø> (-3.72%) ⬇️
hardware_interface/src/sensor.cpp 50.52% <ø> (ø)
hardware_interface/src/system.cpp 55.45% <ø> (ø)
...rface/test/mock_components/test_generic_system.cpp 9.14% <ø> (ø)
...dware_interface/test/test_component_interfaces.cpp 32.44% <ø> (+4.25%) ⬆️
... and 69 more

... and 18 files with indirect coverage changes

@bmagyar bmagyar merged commit 7422030 into master Mar 20, 2023
1 check passed
@bmagyar bmagyar deleted the forward-port-953 branch December 4, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants