Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Example 14] Modular robot with actuators not providing states, with additional sensors #147

Closed
wants to merge 4 commits into from

Conversation

destogl
Copy link
Member

@destogl destogl commented Dec 20, 2021

Adding example 6 where actuatore does not provides state but separate sensors are used for it.

The "mechanical connection" is implemented using socket communication.

This is the last example for differnet architectures. The rest is moresty different type combination that need further development of the framework.


@destogl destogl self-assigned this Dec 20, 2021
@destogl destogl requested a review from bmagyar December 20, 2021 21:17
jackcenter
jackcenter previously approved these changes Feb 9, 2022
Copy link
Contributor

@jackcenter jackcenter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The demo worked as expected after following the commands and all of the expected interfaces/controllers come up. I think there is a typo under the update to example 3, but the link works regardless.

README.md Outdated Show resolved Hide resolved
"controllers_file": "rrbot_modular_actuators_without_feedback_sensors_for_position_feedback.yaml",
"description_file": "rrbot_modular_actuators_without_feedback_sensors_for_position_feedback.urdf.xacro",
"prefix": prefix,
"use_fake_hardware": "false",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weren't we using fake hardware for the demo? Seems to work regardless of if this is set as true or false.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is actually also an simple implementation of an example hardware. But yes, except output in terminal id does not matter if fake or "real" hardware is used.

@@ -492,6 +492,30 @@ Available controllers:
Commanding the robot: see the commands below.


### Example 6: "Modular Robots with actuators not providing states and with additional sensors"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it's worth mentioning the slowdown here? The example sends a '5' command to the velocity controller but it spins much slower (due to a default slowdown of 50) which may or may not be confusing to people.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slowdown should just make the movement "smoother", i.e., mock dynamics. Otherwise, robot would jump to the goal immediately.

Co-authored-by: Jack <jack.center@picknik.ai>
@destogl destogl marked this pull request as draft February 23, 2022 18:19
@destogl destogl marked this pull request as ready for review February 23, 2022 18:20
Copy link

@DasRoteSkelett DasRoteSkelett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at the C++ part and it looks good to me, as parts of the code, that are not optimal (i.e. missing error checks) are clearly marked as not suited for production.

@destogl
Copy link
Member Author

destogl commented Feb 28, 2022

@DasRoteSkelett did you try to execute the example according to instructions? Did it work?

(i.e. missing error checks) are clearly marked as not suited for production.

This is the repository with examples, so we will likely not add any tests for this code.

@christophfroehlich christophfroehlich added the New example This PR is proposing a new example. label Mar 17, 2023
@christophfroehlich christophfroehlich changed the title Add example 6 [Example 14] Modular robot with actuators not providing states, with additional sensors Aug 5, 2023
christophfroehlich added a commit to christophfroehlich/ros2_control_demos that referenced this pull request Aug 5, 2023
christophfroehlich added a commit to christophfroehlich/ros2_control_demos that referenced this pull request Aug 5, 2023
Co-authored-by: Denis Štogl <denis@stogl.de>
Co-authored-by: Jack <jack.center@picknik.ai>
@christophfroehlich
Copy link
Contributor

Closing in favor of #334

christophfroehlich added a commit to christophfroehlich/ros2_control_demos that referenced this pull request Aug 5, 2023
Co-authored-by: Denis Štogl <denis@stogl.de>
Co-authored-by: Jack <jack.d.center@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New example This PR is proposing a new example.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants