Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Example 7] Full example for 6 revolute joint robot #201

Merged
merged 34 commits into from
Aug 4, 2023
Merged

[Example 7] Full example for 6 revolute joint robot #201

merged 34 commits into from
Aug 4, 2023

Conversation

pac48
Copy link
Contributor

@pac48 pac48 commented Jul 27, 2022 •
edited
Loading

This change adds an minimal example to control a custom 6 DOF robot with ros2_control. The README acts as a tutorial for intermediate ROS 2 users.

@pac48 pac48 force-pushed the full-example-tutorial branch 4 times, most recently from a3661ec to f22c898 Compare July 28, 2022 14:56
@christophfroehlich christophfroehlich added the New example This PR is proposing a new example. label Mar 17, 2023
@destogl destogl mentioned this pull request Aug 1, 2023
Closed
@christophfroehlich
Copy link
Contributor

christophfroehlich commented Aug 1, 2023 •
edited
Loading

@pac48 I've read the readme and ran the example successfully. Nice and detailed tutorial imho. I'd start now to port that to the structure we use inside this repository. Do you have a use case for the sub-packages? We decided to pack everything within one single example_x package, I'd also apply it to this PR?
And do you have a special copyright owner/license you want for the files?

@christophfroehlich christophfroehlich changed the title Full example for 6 revolute joint robot [Example 7] Full example for 6 revolute joint robot Aug 2, 2023
@christophfroehlich
Copy link
Contributor

@pac48 how did you create r6bot_kinematics.gv? This is not the default tf2_tools output? Would you like to add it to the docs, or should I delete it?

@christophfroehlich christophfroehlich requested review from olivier-stasse and removed request for a10263790 and TomoyaFujita2016 August 2, 2023 09:20
@pac48
Copy link
Contributor Author

pac48 commented Aug 3, 2023

r6bot_kinematics.gv

Thanks @christophfroehlich for getting back to me about this PR. I deleted the r6bot_kinematics.gv file since it is not needed. I appreciate your work to make this example fit the new structure!

@christophfroehlich
Copy link
Contributor

r6bot_kinematics.gv

Thanks @christophfroehlich for getting back to me about this PR. I deleted the r6bot_kinematics.gv file since it is not needed. I appreciate your work to make this example fit the new structure!

We should delete the PDF as well. I was just curious about the gv-file, was this auto-generated?

Are you happy with the license and copyright claims? Then I'm happy to merge ;)

@pac48
Copy link
Contributor Author

pac48 commented Aug 3, 2023

r6bot_kinematics.gv

Thanks @christophfroehlich for getting back to me about this PR. I deleted the r6bot_kinematics.gv file since it is not needed. I appreciate your work to make this example fit the new structure!

We should delete the PDF as well. I was just curious about the gv-file, was this auto-generated?

Are you happy with the license and copyright claims? Then I'm happy to merge ;)

The license and copyright look fine to me. And yes, the file was auto-generated, but I don't remember exactly how since it was a while ago.

@christophfroehlich christophfroehlich enabled auto-merge (squash) August 4, 2023 07:36
@christophfroehlich christophfroehlich merged commit 09b357a into ros-controls:master Aug 4, 2023
12 checks passed
@christophfroehlich
Copy link
Contributor

@Mergifyio backport humble

@mergify
Copy link
Contributor

mergify bot commented Aug 4, 2023 •
edited
Loading

backport humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 4, 2023
@pac48 @mergify
[Example 7] Full example for 6 revolute joint robot (#201)
bb93f45 
This change adds an minimal example to control a custom 6 DOF robot with ros2_control. The README acts as a tutorial for intermediate ROS 2 users.

---------

Co-authored-by: Christoph Froehlich <christoph.froehlich@ait.ac.at>
(cherry picked from commit 09b357a)
@mergify mergify bot mentioned this pull request Aug 4, 2023
Merged
christophfroehlich pushed a commit that referenced this pull request Aug 4, 2023
@mergify @pac48
[Example 7] Full example for 6 revolute joint robot (#201) (#333)
83eaa4f 
This change adds an minimal example to control a custom 6 DOF robot with ros2_control. The README acts as a tutorial for intermediate ROS 2 users.

---------

Co-authored-by: Christoph Froehlich <christoph.froehlich@ait.ac.at>
(cherry picked from commit 09b357a)

Co-authored-by: Paul Gesel <paulgesel@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christophfroehlich christophfroehlich christophfroehlich approved these changes

@bijoua29 bijoua29 Awaiting requested review from bijoua29

@bmagyar bmagyar Awaiting requested review from bmagyar

@destogl destogl Awaiting requested review from destogl

@jaron-l jaron-l Awaiting requested review from jaron-l

@livanov93 livanov93 Awaiting requested review from livanov93

@olivier-stasse olivier-stasse Awaiting requested review from olivier-stasse

Assignees
No one assigned
Labels
New example This PR is proposing a new example.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pac48 @christophfroehlich