Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 use pre-commit workflow from ros2_control_ci #458

Merged
merged 4 commits into from
Mar 7, 2024
Merged

Conversation

christophfroehlich
Copy link
Contributor

  • use pre-commit workflow from ros2_control_ci (replace old format and lint jobs)
  • update pre-commit
  • fix contributing.md

Copy link
Member

@progtologist progtologist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saikishor saikishor merged commit 7dc41df into master Mar 7, 2024
8 checks passed
@saikishor saikishor deleted the ci_precommit branch March 7, 2024 08:25
mergify bot pushed a commit that referenced this pull request Mar 7, 2024
* Use new pre-commit wf from ros2_control_ci

* Update pre-commit config

* Fix license text in contributing.md

* Add update-pre-commit

(cherry picked from commit 7dc41df)

# Conflicts:
#	.github/workflows/ci-ros-lint.yml
mergify bot pushed a commit that referenced this pull request Mar 7, 2024
* Use new pre-commit wf from ros2_control_ci

* Update pre-commit config

* Fix license text in contributing.md

* Add update-pre-commit

(cherry picked from commit 7dc41df)
christophfroehlich added a commit that referenced this pull request Mar 7, 2024
* Use new pre-commit wf from ros2_control_ci

* Update pre-commit config

* Fix license text in contributing.md

(cherry picked from commit 7dc41df)

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
christophfroehlich added a commit that referenced this pull request Mar 7, 2024
* Use new pre-commit wf from ros2_control_ci

* Update pre-commit config

* Fix license text in contributing.md

* Add update-pre-commit
christophfroehlich added a commit that referenced this pull request Mar 7, 2024
* Use new pre-commit wf from ros2_control_ci

* Update pre-commit config

* Fix license text in contributing.md

* Add update-pre-commit

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants