Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update publishing rate for example_2 in userdoc.rst #573

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

Pratham-Pandey
Copy link
Contributor

Updated publishing rate to match with diff_drive controller update rate (as in 3rd line of config file).

Updated publishing rate to match with diff_drive controller update rate (as in config file).
@saikishor saikishor merged commit 3592198 into ros-controls:master Aug 22, 2024
6 checks passed
@christophfroehlich
Copy link
Contributor

This would not be necessary actually, the controller just uses the old command until it gets a new one 🤷‍♂️

@christophfroehlich
Copy link
Contributor

@Mergifyio backport iron humble

Copy link
Contributor

mergify bot commented Aug 22, 2024

backport iron humble

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 22, 2024
Updated publishing rate to match with diff_drive controller update rate (as in config file).

(cherry picked from commit 3592198)
mergify bot pushed a commit that referenced this pull request Aug 22, 2024
Updated publishing rate to match with diff_drive controller update rate (as in config file).

(cherry picked from commit 3592198)
christophfroehlich pushed a commit that referenced this pull request Aug 22, 2024
Updated publishing rate to match with diff_drive controller update rate (as in config file).

(cherry picked from commit 3592198)

Co-authored-by: Pratham <85839299+Pratham-Pandey@users.noreply.github.com>
christophfroehlich pushed a commit that referenced this pull request Aug 22, 2024
Updated publishing rate to match with diff_drive controller update rate (as in config file).

(cherry picked from commit 3592198)

Co-authored-by: Pratham <85839299+Pratham-Pandey@users.noreply.github.com>
@Pratham-Pandey
Copy link
Contributor Author

This would not be necessary actually, the controller just uses the old command until it gets a new one 🤷‍♂️

Would not this create unnecessary load(although negligible) on the system as publishing more frequently would use more resource?

@christophfroehlich
Copy link
Contributor

Sorry, forget my comment. I was wrong and thought you increased the update rate. Reducing it is totally fine, there is no reason for sending this faster here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants