Update publishing rate for example_2 in userdoc.rst #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated publishing rate to match with diff_drive controller update rate (as in config file).
github-actions
bot
requested review from
bmagyar,
destogl,
fmauch,
mcbed,
progtologist,
saikishor and
VanshGehlot
saikishor
approved these changes
Aug 22, 2024
|
This would not be necessary actually, the controller just uses the old command until it gets a new one 🤷♂️ |
|
@Mergifyio backport iron humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
Updated publishing rate to match with diff_drive controller update rate (as in config file). (cherry picked from commit 3592198)
mergify bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
Updated publishing rate to match with diff_drive controller update rate (as in config file). (cherry picked from commit 3592198)
This was referenced Aug 22, 2024
christophfroehlich
pushed a commit
that referenced
this pull request
Aug 22, 2024
christophfroehlich
pushed a commit
that referenced
this pull request
Aug 22, 2024
Would not this create unnecessary load(although negligible) on the system as publishing more frequently would use more resource? |
|
Sorry, forget my comment. I was wrong and thought you increased the update rate. Reducing it is totally fine, there is no reason for sending this faster here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated publishing rate to match with diff_drive controller update rate (as in 3rd line of config file).