[Iron] Added stereo calibration using aruco markers #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MRo47
changed the title
ahcorde
requested changes
Apr 30, 2024
ahcorde
pushed a commit
that referenced
this pull request
Jun 3, 2024
From #972 Doing this first for rolling. This was a TODO in the repository, opening this PR to add this feature. - The main issue why this wasn't possible imo is the way `mk_obj_points` works. I'm using the inbuilt opencv function to get the points there. - The other is a condition when aruco markers are detected they are added as good points, This is fine in case of mono but in stereo these have to be the same number as the object points to find matches although this should be possible with aruco.
mergify bot
pushed a commit
that referenced
this pull request
Jun 20, 2024
From #972 Doing this first for rolling. This was a TODO in the repository, opening this PR to add this feature. - The main issue why this wasn't possible imo is the way `mk_obj_points` works. I'm using the inbuilt opencv function to get the points there. - The other is a condition when aruco markers are detected they are added as good points, This is fine in case of mono but in stereo these have to be the same number as the object points to find matches although this should be possible with aruco. (cherry picked from commit efb9005)
mergify bot
pushed a commit
that referenced
this pull request
Jun 20, 2024
From #972 Doing this first for rolling. This was a TODO in the repository, opening this PR to add this feature. - The main issue why this wasn't possible imo is the way `mk_obj_points` works. I'm using the inbuilt opencv function to get the points there. - The other is a condition when aruco markers are detected they are added as good points, This is fine in case of mono but in stereo these have to be the same number as the object points to find matches although this should be possible with aruco. (cherry picked from commit efb9005) # Conflicts: # camera_calibration/src/camera_calibration/calibrator.py
|
Closing this PR in favour of this other #1003 created with mergify |
ahcorde
pushed a commit
that referenced
this pull request
Jul 16, 2024
From #972 Doing this first for rolling. This was a TODO in the repository, opening this PR to add this feature. - The main issue why this wasn't possible imo is the way `mk_obj_points` works. I'm using the inbuilt opencv function to get the points there. - The other is a condition when aruco markers are detected they are added as good points, This is fine in case of mono but in stereo these have to be the same number as the object points to find matches although this should be possible with aruco.<hr>This is an automatic backport of pull request #976 done by [Mergify](https://mergify.com). Co-authored-by: Myron Rodrigues <41271144+MRo47@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a TODO in the repository, opening this PR to add this feature.
mk_obj_pointsworks. I'm using the inbuilt opencv function to get the points there.Noob to contributing in this repo, any guidelines, rules I should be following before doing PR's here?