Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix service crash when non-arsenal errors is sent to delete route #2267

Merged
merged 12 commits into from
Nov 26, 2024

Enforce using the arsenal error in route utils

c95d269
Select commit
Loading
Failed to load commit list.
Merged

Fix service crash when non-arsenal errors is sent to delete route #2267

Enforce using the arsenal error in route utils
c95d269
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 26, 2024 in 0s

66.12% (+1.22%) compared to 6a33bcc

View this Pull Request on Codecov

66.12% (+1.22%) compared to 6a33bcc

Details

Codecov Report

Attention: Patch coverage is 87.03704% with 7 lines in your changes missing coverage. Please review.

Project coverage is 66.12%. Comparing base (6a33bcc) to head (c95d269).

Files with missing lines Patch % Lines
lib/s3routes/routesUtils.ts 85.71% 7 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           development/8.1    #2267      +/-   ##
===================================================
+ Coverage            64.90%   66.12%   +1.22%     
===================================================
  Files                  215      215              
  Lines                17298    17325      +27     
  Branches              3514     3552      +38     
===================================================
+ Hits                 11228    11457     +229     
+ Misses                6055     5853     -202     
  Partials                15       15              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.