Fix service crash when non-arsenal errors is sent to delete route

lib/s3routes/routes/routeDELETE.ts

@@ -1,7 +1,7 @@
 import { RequestLogger } from 'werelogs';
 
 import * as routesUtils from '../routesUtils';
-import errors from '../../errors';
+import errors, { ArsenalError } from '../../errors';
 import StatsClient from '../../metrics/StatsClient';
 import * as http from 'http';
 
@@ -54,11 +54,14 @@ export default function routeDELETE(
         api.callApiMethod('objectDelete', request, response, log,
             (err, corsHeaders) => {
                 /*
-              * Since AWS expects a 204 regardless of the existence of
-              the object, the errors NoSuchKey and NoSuchVersion should not
-              * be sent back as a response.
-              */
-                if (err && !err.is.NoSuchKey && !err.is.NoSuchVersion) {
+                 * Since AWS expects a 204 regardless of the existence of
+                 * the object, the errors NoSuchKey and NoSuchVersion should not
+                 * be sent back as a response.
+                 */
+                if (err && (
+                    !(err instanceof ArsenalError) || 
+                    (!err.is.NoSuchKey && err.is.NoSuchVersion)
+                )) {
                     return routesUtils.responseNoBody(err, corsHeaders,
                         response, undefined, log);
                 }

lib/s3routes/routes/routeGET.ts

@@ -87,8 +87,6 @@ export default function routerGET(
                     if (resMetaHeaders && resMetaHeaders['Content-Length']) {
                         contentLength = resMetaHeaders['Content-Length'];
                     }
-                    // TODO ARSN-216 Fix logger
-                    // @ts-ignore
                     log.end().addDefaultFields({ contentLength });
                     routesUtils.statsReport500(err, statsClient);
                     return routesUtils.responseStreamData(err, query,

lib/s3routes/routes/routePUT.ts

@@ -225,9 +225,7 @@ export default function routePUT(
                 return routesUtils.responseNoBody(errors.BadRequest,
                     null, response, 400, log);
             }
-            // TODO ARSN-216 What's happening?
-            // @ts-ignore
-            log.end().addDefaultFields({ contentLength: request.parsedContentLength });
+            log.end().addDefaultFields({ contentLength: parsedContentLength });
             api.callApiMethod('objectPut', request, response, log,
                 (err, resHeaders) => {
                     routesUtils.statsReport500(err, statsClient);