Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix service crash when non-arsenal errors is sent to delete route #2267

Merged
merged 12 commits into from
Nov 26, 2024
Merged

Fix service crash when non-arsenal errors is sent to delete route #2267

merged 12 commits into from
Nov 26, 2024

Commits on Nov 14, 2024

  1. Fix crash when error is not an arsenal error in route 

    - Error may be returned by modules not using Arsenal
- In this case, any non-arsenal error reaching this code would
  cause a crash of the service.

Issue: ARSN-441
    @williamlardier
    williamlardier committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    48345e5 View commit details
    Browse the repository at this point in the history

  2. Fix logger usage 

    Issue: ARSN-216, ARSN-441
    @williamlardier
    williamlardier committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    d523954 View commit details
    Browse the repository at this point in the history

  3. Extend the route types to support non-arsenal errors 

    Arsenal routes today are used in cloudserver, that calls these
callback functions using, most of the time, Arsenal errors. But
sometimes, especially when using modules, such as hdclient or
others, we might not return an Arsenal error. In this case, we
still try to access undefined properties, eventually leading to
strange responses to the client.

The changes are introducing support for traditional Error objects,
so that we can safely pass any error from a module used in an API
call.
    @williamlardier
    williamlardier committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    670b9d5 View commit details
    Browse the repository at this point in the history

  4. Implement unit tests for all routes 

    Issue: ARSN-441
    @williamlardier
    williamlardier committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    500e8c5 View commit details
    Browse the repository at this point in the history

  5. Test routesUtils 

    Issue: ARSN-441
    @williamlardier
    williamlardier committed Nov 14, 2024
    Configuration menu
    Copy the full SHA
    f811f8d View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. End logger in Put route 

    Issue: ARSN-441
    @williamlardier
    williamlardier committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    3d9dd33 View commit details
    Browse the repository at this point in the history

  2. Bump werelogs 

    Issue: ARSN-441
    @williamlardier
    williamlardier committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    9e08031 View commit details
    Browse the repository at this point in the history

  3. Go back to info logs after end() call following types fixes 

    Issue: ARSN-441
    @williamlardier
    williamlardier committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    c81f6df View commit details
    Browse the repository at this point in the history

Commits on Nov 26, 2024

  1. Ensure no behavior change with non arsenal errors processing 

    Issue: ARSN-441
    @williamlardier
    williamlardier committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    732cfa8 View commit details
    Browse the repository at this point in the history

  2. Do not make assumption in routes for error instances 

    Issue: ARSN-441
    @williamlardier
    williamlardier committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    bb1dd25 View commit details
    Browse the repository at this point in the history

  3. Remove type casting in website routes 

    Issue: ARSN-441
    @williamlardier
    williamlardier committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    fc049d0 View commit details
    Browse the repository at this point in the history

  4. Enforce using the arsenal error in route utils 

    Issue: ARSN-441
    @williamlardier
    williamlardier committed Nov 26, 2024
    Configuration menu
    Copy the full SHA
    c95d269 View commit details
    Browse the repository at this point in the history